Be more specific in the packages we suggest for installation #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadeallenx
reviewed
Nov 9, 2023
kerl
Outdated
| _KPP_rhel_probe="_rpm" | ||
|
|
||
| _KPP_ubuntu_pkgs="libssl-dev make automake autoconf libncurses5-dev gcc g++" | ||
| _KPP_ubuntu_pkgs="libssl-dev make libncurses5-dev gcc g++" | ||
| if [ "$KERL_BUILD_BACKEND" = 'git' ]; then |
There was a problem hiding this comment.
seems like this could be a common check for all linux flavors?
There was a problem hiding this comment.
Yeah, I thought about it. We could do the same exercise for other packages, but then I thought "We decided to keep them separate before, so...". I don't mind separating them, but, in that case, I'll try to aggregate as much of the common stuff as possible.
There was a problem hiding this comment.
i think it makes sense to collapse common things into a common code path
There was a problem hiding this comment.
jadeallenx
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only suggest
automakeandautoconfwhenKERL_BUILD_BACKENDisgit.Closes #249.
Further considerations
This is at the cost of a bit more maintenance, though most likely the software lists aren't bound to change much any time soon.