Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more specific in the packages we suggest for installation #491

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Be more specific in the packages we suggest for installation #491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac7b018
Be more specific in the packages we suggest for installation
paulo-ferraz-oliveira Nov 9, 2023
0bc39e5
Act on review comment: collapse common things into a common code path
paulo-ferraz-oliveira Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 14 additions & 6 deletions kerl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,28 +873,32 @@ _apk() {
echo "apk -e info \"$1\""
}

common_ALL_pkgs="gcc make"
common_ALL_BUILD_BACKEND_git_pkgs="automake autoconf"
common_debian_pkgs="${common_ALL_pkgs} libssl-dev libncurses5-dev g++"

# To add package guessing magic for your Linux distro/package,
# create a variable named _KPP_<distro>_pkgs where the content
# is an array with packages, and then create a unique probe
# command, in variable _KPP_<distro>_probe to check from the package manager.
# It should return 0 if package installation is Ok, non-0 otherwise.

_KPP_alpine_pkgs="openssl-dev make automake autoconf ncurses-dev gcc g++"
_KPP_alpine_pkgs="${common_ALL_pkgs} openssl-dev ncurses-dev g++"
_KPP_alpine_probe="_apk"

_KPP_debian_pkgs="libssl-dev make automake autoconf libncurses5-dev gcc g++"
_KPP_debian_pkgs=${common_debian_pkgs}
_KPP_debian_probe="_dpkg"

_KPP_fedora_pkgs="openssl-devel make automake autoconf ncurses-devel gcc g++"
_KPP_fedora_pkgs="${common_ALL_pkgs} openssl-devel ncurses-devel g++"
_KPP_fedora_probe="_rpm"

_KPP_linuxmint_pkgs="libssl-dev make automake autoconf libncurses5-dev gcc g++"
_KPP_linuxmint_pkgs=${common_debian_pkgs}
_KPP_linuxmint_probe="_dpkg"

_KPP_rhel_pkgs="openssl-devel make automake autoconf ncurses-devel gcc gcc-c++"
_KPP_rhel_pkgs="${common_ALL_pkgs} openssl-devel ncurses-devel gcc-c++"
_KPP_rhel_probe="_rpm"

_KPP_ubuntu_pkgs="libssl-dev make automake autoconf libncurses5-dev gcc g++"
_KPP_ubuntu_pkgs=${common_debian_pkgs}
_KPP_ubuntu_probe="_dpkg"

parse_os_release() {
Expand Down Expand Up @@ -952,6 +956,10 @@ probe_pkgs() {
fi

kpp=$(eval echo \$_KPP_"${os_release_id}"_pkgs)
if [ "$KERL_BUILD_BACKEND" = 'git' ]; then
kpp="${common_ALL_BUILD_BACKEND_git_pkgs} ${kpp}"
fi

if [ -n "${kpp}" ]; then
log_build_entry "[packages] Found package declarations for your Linux distro: ${os_release_id}"
for pkg in ${kpp}; do
Expand Down