Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Zsh completion scripts #497

Merged
merged 1 commit into from Dec 16, 2023

Conversation

halturin
Copy link
Contributor

@halturin halturin commented Dec 8, 2023

Description

current version of zsh_completion/_kerl is invalid. this PR fixes this problem.

@paulo-ferraz-oliveira paulo-ferraz-oliveira linked an issue Dec 16, 2023 that may be closed by this pull request
@paulo-ferraz-oliveira
Copy link
Contributor

👋, @halturin.

Thanks for this 😄. This issue was introduced by me a few months back (#418). I don't know what kind of tests I did back then 🙃 but we should probably also at least statically check the completion files in CI, if it's somehow possible.

Regarding linking the pr to an issue I don't think it works in the pr title, but since you replaced the pr template (https://github.com/kerl/kerl/blob/master/.github/pull_request_template.md) you probably missed it too.

I'll (hopefully soonish) update the completion files, since they seem outdated in many places, but still have the wip branch locally, not pushed.

I'll approve the CI run and if all's good merge this. 👍

@paulo-ferraz-oliveira
Copy link
Contributor

Yeah, I now remember I already checked using shfmt and shellcheck on the ZSh completion but hit walls, so gave up:

@paulo-ferraz-oliveira
Copy link
Contributor

Failing check on macos-13, unexplicably ("Update env." step takes 1 min in some workflows, 7 min when failing 😄). Will try to fix it in a separate pull request.

@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title fix #496. missing code Fix broken Zsh completion scripts Dec 16, 2023
@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit b98db4c into kerl:master Dec 16, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zsh autocompletion failed
2 participants