Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Space not opening the Conex popup [FF 59.0b7 on Mac OS] #154

Closed
fturcheti opened this issue Feb 7, 2018 · 17 comments
Closed

Ctrl+Space not opening the Conex popup [FF 59.0b7 on Mac OS] #154

fturcheti opened this issue Feb 7, 2018 · 17 comments

Comments

@fturcheti
Copy link

The shortcut to open the Conex popup – Ctrl+Space – is not working here. I'm running Firefox Quantum 59.0b7 on Mac OS Sierra 10.12.6.

To make sure this is not related to other extensions or custom settings, I've cloned Conex and tested it with web-ext run, but the problem persisted.

@kesselborn
Copy link
Owner

kesselborn commented Feb 7, 2018 via email

@kesselborn
Copy link
Owner

do you have a mac os x wide shortcut mapped to this combination?

@fturcheti
Copy link
Author

Yes, that's indeed weird... I tried to disable some tools that could be causing some conflict but I didn't find the the source of the problem yet.

Anyway, if I'm the only one facing this issue it must be something with my system. I'll try to investigate a bit further and if I discover something I'll come back with more information.

@fturcheti
Copy link
Author

I just found the shortcut that was causing this conflict. Ctrl+Space was set to "Select the previous input source" in the System Preferences – under Keyboard > Shortcuts > Input Sources [1]. Disabling this shortcut fixed the problem.

It seems that Ctrl+Space is the default shortcut for this system action, so maybe it's a good idea to change it in the add-on, or at least to advise users about this possible conflict.

–––

[1]: If you're not seeing these "Input Sources" shortcuts, you have to add multiple input sources first.

@smichel17
Copy link
Contributor

@fturcheti conex has been through 4 or 5 different shortcuts and there's always something that conflicts. It really ought to be configurable, but that's a whole 'nother problem. Honestly it really feels like a Firefox bug that users can't configure extension hotkeys.

@kesselborn
Copy link
Owner

yeah ... who would have thought, that keyboard shortcuts is one of the hardest problems :/
Does somebody know, what the original tabgroup shortcut for searching and moving tabs was?
I can create multiple shortcuts for the same action -- perhaps that's a way to go until configuration is possible.
And damned: @grahamperrin actually already mentioned this conflict but I dismissed it, as it wasn't that case in my installation -- don't know if I remapped it.

Thanks, I'll try to think about something

@fturcheti
Copy link
Author

@smichel17 I totally agree, it would be much better if Firefox had an easy way to set these shortcuts. Defining a hard-coded is certainly a difficult task, it will always bring problems to someone.

@kesselborn if I can remember, there wasn't a shortcut to "move a tab to another group" in the original TabGroups. I think the default shortcuts were:

  • Cmd+Shift+e: Show tab groups (the grid overview or the smaller popup according to the user setup)
  • Ctrl+`: Go to next group
  • Ctrl+Shift+`: Go to previous group

@kesselborn
Copy link
Owner

kesselborn commented Feb 14, 2018 via email

@fturcheti
Copy link
Author

Looking at the source code, it seems that there wasn't a default shortcut for this action: https://github.com/Quicksaver/Tab-Groups/blob/master/resource/defaults.js#L45

I remember to use Cmd+Shift+E for opening the Tab Groups popup, as I preferred this compact mode instead of the grid view. "Simplified Tab Groups for Firefox", another add-on in the lineage of Quicksaver's Tab Groups (and the one I was using before FF57), also uses Cmd+Shift+E as the shortcut for displaying its tab groups popup: https://github.com/denschub/firefox-tabgroups/blob/develop/src/index.js#L89

But if you don't want to go with Cmd+Shift+E, another suggestion is to choose Cmd+Shift+\, as Safari uses this shortcut for showing its tabs overview.

@kesselborn
Copy link
Owner

kesselborn commented Feb 14, 2018 via email

@fturcheti
Copy link
Author

Maybe you could change the shortcuts to:

  • Cmd+Shift+E: open the popup
  • Cmd+Shift+M: move tabs between groups

@kesselborn
Copy link
Owner

kesselborn commented Feb 14, 2018 via email

@smichel17
Copy link
Contributor

Ctrl+e was the tab groups shortcut to open the pop-up, while Ctrl+Shift+e opened the panorama-like view.

I personally didn't love this one because I accidentally hit Ctrl+w and closed my tab instead all too often.

@fturcheti
Copy link
Author

@kesselborn I think the better solution for the moment is to leave the shortcuts as they are and advert users about this possible conflict, also indicating that Firefox will soon provide the API for webextensions to change predefined shortcuts.

I always get lost navigating these Firefox bugs, but it seems that this functionality is really coming: https://bugzilla.mozilla.org/show_bug.cgi?id=1421811

@kesselborn
Copy link
Owner

kesselborn commented Feb 14, 2018 via email

@kesselborn
Copy link
Owner

closing this for #155 as custom remappings will solve your problem as well ... thanks for the investigation @fturcheti

@kesselborn
Copy link
Owner

fixed in dc3b963 (v0.3.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants