Check for retreat options before win #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if a player got 18 centers in the fall the game would declare them the winner before the retreat phase. Now if there is a retreat phase, the game will wait and check for the winner after retreats are done.
|
This has been live on vDip for some time now without causing any problems. Local testing was also done, but I will not push this live until I have a game live on the server in the fall season with 17 centers and a retreat into an open center available for testing. If the live test does not work for any reason I'll be rolling back this change immediately due to the wide scope of games it could impact. |
|
Will correct #196 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a player got 18 centers in the fall the game would declare
them the winner before the retreat phase. Now if there is a retreat
phase, the game will wait and check for the winner after retreats are
done.