fix(ssh): missing Thread.join() on the log threads (#55)

kestra-io · Apr 3, 2023 · 886ba21 · 886ba21
1 parent f57925a
commit 886ba21
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/main/java/io/kestra/plugin/fs/ssh/Command.java b/src/main/java/io/kestra/plugin/fs/ssh/Command.java
@@ -97,14 +97,17 @@ public VoidOutput run(RunContext runContext) throws Exception {
             channel.setCommand(String.join("\n", renderedCommands));
             channel.setOutputStream(new BufferedOutputStream(outStream), true);
             channel.setErrStream(new BufferedOutputStream(errStream), true);
-            threadLogSupplier(runContext).call(inStream, false);
-            threadLogSupplier(runContext).call(inErrStream, true);
+            var stdOut = threadLogSupplier(runContext).call(inStream, false);
+            var stdErr = threadLogSupplier(runContext).call(inErrStream, true);
 
             channel.connect();
             while (channel.isConnected()) {
                 Thread.sleep(SLEEP_DELAY_MS);
             }
 
+            stdOut.join();
+            stdErr.join();
+
             if(channel.getExitStatus() != 0) {
                 throw new Exception("SSH command fails with exit status " + channel.getExitStatus());
             }