Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of embedded operators #114

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Refactor of embedded operators #114

merged 3 commits into from
Jun 4, 2024

Conversation

andgoldschmidt
Copy link
Member

Closes #113

Embedded operators interface makes sure that a user is only ever passing subspace operators,

U_goal = EmbeddedOperator(
    GATES[:CZ],
    system,
    subspace=get_subspace_indices([1:2, 1:2], [3, 3])
)

The purpose of this PR is to reduce the amount of code in embedded operators to essential features.

NOTE: Composite systems do not have test cases; hence, while expected behavior shouldn't have changed, there aren't any guarantees, currently.

@aarontrowbridge
Copy link
Collaborator

We're definitely going to want to refactor this at some point to utilize Qobjs from QuantumToolbox.jl. But for now, whatever is easier is best.

@aarontrowbridge aarontrowbridge merged commit d61a076 into main Jun 4, 2024
3 checks passed
@andgoldschmidt andgoldschmidt deleted the feature_embedop branch June 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Construct embedded operator from levels, embedding, and matrix.
2 participants