Fix for alpine3.10 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- limit line length (does not affect rendering) - add first-level header first - converted google domain from hyperlinks into plain text - add language specification for code fragments Here is a command to run Markdown syntax check: ``` docker run --rm --network none -v "/$PWD:/markdown:ro" 06kellyjac/markdownlint-cli:0.21.0-alpine //markdown ``` All the changes above fixed the following list of errors: ``` /markdown/README.md:1 MD041/first-line-heading/first-line-h1 First line in file should be a top level heading [Context: "## wait-for-it"] /markdown/README.md:3 MD013/line-length Line length [Expected: 80; Actual: 280] /markdown/README.md:7 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] /markdown/README.md:21 MD013/line-length Line length [Expected: 80; Actual: 131] /markdown/README.md:23 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] /markdown/README.md:30 MD013/line-length Line length [Expected: 80; Actual: 124] /markdown/README.md:32 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] /markdown/README.md:39 MD013/line-length Line length [Expected: 80; Actual: 239] /markdown/README.md:41 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] /markdown/README.md:48 MD013/line-length Line length [Expected: 80; Actual: 185] /markdown/README.md:50 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"] ```
Added support for new busybox timeout version
* New port for every test
Containertests
README: fix markdown formatting
Removed dtt from tests
Publish to PHP Composer
Avoid sending a newline character which confuses servers.
|
Please hold on merging until I can double of check a couple of things. I wanted to get the diff showing so I can see what we are working with here |
Busybox updated timeout's flags to match coreutils. This broke the script that was specifically dealing with BusyBox being different from coreutils. To fix the problem without breaking support for older versions of busy box, this a version check of busybox to determine which version of the flags to use. Note, the changes use bash's regular expression's BASH_REMATCH to get the job done. For Alpine users, this means you'll have to install bash and execute wait-for-it using bash.
alallier
force-pushed
the
fixForAlpine3-10
branch
from
d771dac
to
913b6b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the fork from project upstream and cherry picked a fix for Alpine Linux 3.10 and greater out of vishnubob#81
Context: