Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs are lacking #420

Closed
wcooley opened this issue Feb 8, 2019 · 4 comments
Closed

API docs are lacking #420

wcooley opened this issue Feb 8, 2019 · 4 comments
Assignees
Labels
good first issue need dev When a PR has been reviewed but still need developments
Milestone

Comments

@wcooley
Copy link

wcooley commented Feb 8, 2019

The "API" section of the documentation is a bit thin. For example, vcr.request.Request only includes the __init__ method, not any of the properties or methods.

I presume this is because there are no docstrings in the missing methods and the "undoc-members" is not enabled in the autodoc default options. Knowing that the method exists and seeing the signature would be better than nothing, even if there aren't actual docstrings.

I think all that would need to be done is to add to conf.py:

autodoc_default_options = {
    'members': None,
    'undoc-members': None,
}
@neozenith
Copy link
Collaborator

Happy to accept a pull request if you have the time to assist with this

@neozenith neozenith added need dev When a PR has been reviewed but still need developments good first issue labels Jul 3, 2019
@neozenith neozenith added this to Quick Wins in Issue Triage Kanban Jul 3, 2019
@neozenith neozenith added this to the v2.1.x milestone Aug 7, 2019
@neozenith neozenith self-assigned this Aug 7, 2019
@neozenith neozenith modified the milestones: v2.1.x, v2.2.x Aug 8, 2019
@neozenith neozenith removed their assignment Aug 8, 2019
@neozenith
Copy link
Collaborator

neozenith commented Aug 8, 2019

I don't have the bandwidth to chase this one up sorry. Will accept PRs though.

@neozenith neozenith self-assigned this Aug 8, 2019
@neozenith
Copy link
Collaborator

Actually, scratch that. I was added as a maintainer of the RTD project now and it's bugging me that this isn't sorted. I'll chase this up.

@neozenith
Copy link
Collaborator

This is getting addressed in #499

Issue Triage Kanban automation moved this from Quick Wins to Closed Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue need dev When a PR has been reviewed but still need developments
Projects
Development

No branches or pull requests

2 participants