Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the cassette failure logs #459

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

arthurHamon2
Copy link
Collaborator

I'have played a bit with the unreleased version of vcrpy and find out the failure messages where a bit verbose. This PR tries to make thing simple and smoother :)

@neozenith
Copy link
Collaborator

I have a few azure pipelines at work which are running these steps:

    python -m pip install --upgrade pip
    pip install pipenv
    pipenv --rm
    pipenv install --dev

    # Remove PyPI installed vcrpy that pytest-vcr relies on
    pipenv uninstall vcrpy

    # Install bleeding  edge from master
    pipenv install --dev  git+https://github.com/kevin1024/vcrpy#egg=vcr
    pipenv run pip list -v

I will have a bit more time in the next sprint to pay down some tech debt. Let me know how I can help on this PR.

@arthurHamon2 arthurHamon2 force-pushed the fix/improve-cassette-failure-message branch from bb6ed58 to 9f14e14 Compare August 4, 2019 20:11
…tches

The message is less verbose and the display is improved for a better readability.
@arthurHamon2
Copy link
Collaborator Author

@neozenith can you review this ? We should be good after that to write the changelog and do a new release :)

Copy link
Collaborator

@neozenith neozenith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes make the code and the tests a lot cleaner. Great work! 🎉

@neozenith neozenith merged commit caa3a67 into master Aug 5, 2019
@arthurHamon2 arthurHamon2 deleted the fix/improve-cassette-failure-message branch December 23, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants