Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and some bug fixes to make the page compact and tidy. #85

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

baskaran-md
Copy link

When there are more jobs (150+) and mode executors, the current space and other CSS configuration makes the page cluttered. (So spacious!).
This current fixes will provide proper spaces and fixes some mis-alignments on build history and home page.
Also, added some effects to console output. (Inspired from https://github.com/djonsson/jenkins-atlassian-theme)
PS: Each commit message should explain the changes clearly.

@baskaran-md
Copy link
Author

If you wish to see the changes live, i can show you a small demo on our Continuous Integration System. Sorry, I cannot share it public.

@baskaran-md
Copy link
Author

Tested against Jenkins 1.597

@baskaran-md
Copy link
Author

home_page

@baskaran-md
Copy link
Author

Build History
build_history

@baskaran-md
Copy link
Author

Console Output
console_output

@kevinburke
Copy link
Owner

thanks for this! the photos look great, but I am on my phone... will review
the code tomorrow.

Kevin

Kevin Burke
phone: 925.271.7005 | twentymilliseconds.com

On Sat, Jan 24, 2015 at 11:24 PM, Baskaran Deivasigamani <
notifications@github.com> wrote:

Console Output
[image: console_output]
https://cloud.githubusercontent.com/assets/496507/5890765/24112e56-a420-11e4-9cb4-d5837c91d393.png


Reply to this email directly or view it on GitHub
#85 (comment).

@baskaran-md
Copy link
Author

Thank you.

@kevinburke
Copy link
Owner

It's a really good start! Some things to clean up but we will get there. I made comments on the individual commits - looks like those comments are not showing up here.

@baskaran-md
Copy link
Author

Thank you, @kevinburke. I will check those comments and get back to you soon.

@kevinburke
Copy link
Owner

Ok sounds good! Please ping me again when you're ready for another look - I
might miss it otherwise :)

Kevin Burke
phone: 925.271.7005 | twentymilliseconds.com

On Mon, Jan 26, 2015 at 11:03 AM, Baskaran Deivasigamani <
notifications@github.com> wrote:

Thank you, @kevinburke https://github.com/kevinburke. I will check
those comments and get back to you soon.


Reply to this email directly or view it on GitHub
#85 (comment).

    * Fix multi line build titles.
    * Fix table mis-alignment for builds in queue with many parameters.
    * Change padding space for build history, to make it compact.
    * Add logo to jenkins title before the hostname display.
    The logo should be placed inside the userContent folder of the jenkins server.
    If there is no logo file, then title will load as it is. Logo height
    can be controlled with CSS #doony-logo, limit to 33px.
    * Fix issue in displaying logo in jenkins title.
    Tasks were displaced with the empty icons, as unwanted icons are removed. Now tasks in place, aligned.
    * Reduce the margins.
    * Reduce width of grid layout.
    * Remove margin from side panel.
    * Fix title alignment for adding logo.
    * Change size to fit on home page "Status" column.
    * Change doony-circle radius to make it square to fit on build history and "Number of Build" column.
    * Assign fix size to "Number of Builds" Column.
@kevinburkeshyp
Copy link

Any update here?

@baskaran-md
Copy link
Author

I didn't get time to work on this.. Will spend some time during this week..

@aehlke
Copy link

aehlke commented Aug 20, 2015

This would be great to get merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants