Update JWT dependency

[igagankalra]

This updates the deprecated jwt package with the new supported jwt package.

[kevinburke]

Can we just remove the JWT functionality altogether?

…

On Tue, Jul 16, 2024 at 07:22 Gagan Kalra ***@***.***> wrote: This updates the deprecated jwt <https://github.com/dgrijalva/jwt-go> package with the new supported jwt <https://github.com/golang-jwt/jwt> package. ------------------------------ You can view, comment on, or merge this pull request online at: #99 Commit Summary - 76080b6 <76080b6> update dependency File Changes (4 files <https://github.com/kevinburke/twilio-go/pull/99/files>) - *M* go.mod <https://github.com/kevinburke/twilio-go/pull/99/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6> (16) - *M* go.sum <https://github.com/kevinburke/twilio-go/pull/99/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63> (31) - *M* token/access_token_test.go <https://github.com/kevinburke/twilio-go/pull/99/files#diff-50bdc085c3bca769997731e5b463887002048290c5a2c77de8bd888693b04eac> (8) - *M* twilioclient/capabilities_test.go <https://github.com/kevinburke/twilio-go/pull/99/files#diff-b7426eb4e71d844cb602342edf4b0b2d66991a049e1156111c81858f12da2fef> (8) Patch Links: - https://github.com/kevinburke/twilio-go/pull/99.patch - https://github.com/kevinburke/twilio-go/pull/99.diff — Reply to this email directly, view it on GitHub <#99>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABZEI6CO6GJ4O7O74DZCIDZMUUDFAVCNFSM6AAAAABK6WXJRWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYTCMZQGI4TOMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[igagankalra]

Can we just remove the JWT functionality altogether?

You want to get rid of the UTs altogether?

[kevinburke]

Yes - if people need JWT support they can bring their own library, I don’t want to support it or worry about vulnerabilities

…

On Tue, Jul 16, 2024 at 07:25 Gagan Kalra ***@***.***> wrote: Can we just remove the JWT functionality altogether? You want to get rid of the UTs altogether? — Reply to this email directly, view it on GitHub <#99 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABZEIZXRTYMKYBMJXEH3CTZMUUN5AVCNFSM6AAAAABK6WXJRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGA2TONJYGA> . You are receiving this because you commented.Message ID: ***@***.***>

[igagankalra]

Yes - if people need JWT support they can bring their own library, I don’t want to support it or worry about vulnerabilities

Cool, I'll remove the both UTs and update the PR.

[igagankalra]

I have updated the code and even the mod file.

[igagankalra]

Yes - if people need JWT support they can bring their own library, I don’t

want to support it or worry about vulnerabilities

On Tue, Jul 16, 2024 at 07:25 Gagan Kalra @.***> wrote:

Can we just remove the JWT functionality altogether?

You want to get rid of the UTs altogether?

—

Reply to this email directly, view it on GitHub

#99 (comment),

or unsubscribe

https://github.com/notifications/unsubscribe-auth/AABZEIZXRTYMKYBMJXEH3CTZMUUN5AVCNFSM6AAAAABK6WXJRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZRGA2TONJYGA

.

You are receiving this because you commented.Message ID:

@.***>

Hey @kevinburke,
Can we review this?

[kevinburke]

This is an open source project and it's been one hour. I have a day job.

[kevinburke]

This change has been merged

[igagankalra]

This is an open source project and it's been one hour. I have a day job.

Thank you 😅
Sorry for being impatient.