Pass error as 1st pram of callback as per Node.js convention. (Plus other fixes.) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yangzai Thanks will look into it today. |
kevincobain2000
added a commit
that referenced
this pull request
Jun 24, 2015
Pass error as 1st pram of callback as per Node.js convention. (Plus other fixes.)
kevincobain2000
added a commit
that referenced
this pull request
Jun 24, 2015
|
ありがとう！ |
|
Lol, I'm not Japanese but I do know a bit. Thanks for the merge too. Anyway you might consider incrementing the major version since the old parameters might not be compatible. |
kevincobain2000
added a commit
that referenced
this pull request
Jun 24, 2015
|
@yangzai sorry! your name is yang but I got carried away with ur DP! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bluebird, as well as many other modules, expects this convention in order to promisify the methods.
Reference: http://rob.conery.io/2012/02/25/nodejs-callback-conventions-and-your-app/