Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ajax request #1

Merged
merged 1 commit into from Dec 2, 2022
Merged

fix: ajax request #1

merged 1 commit into from Dec 2, 2022

Conversation

nicoschoenteich
Copy link
Contributor

@nicoschoenteich nicoschoenteich commented Dec 1, 2022

Hi @kevindass,
I fixed the ajax request so that it includes the application id when running in the Fiori Launchpad. I build the project and deployed it to CF - it all works fine now:

Screenshot 2022-12-01 at 10 54 39

I had some issues with the npm install, so you might also want to delete the package-lock.json and run a fresh install.

Please let me know in case you have questions.

Best, Nico

@kevindass kevindass merged commit 4aaf848 into kevindass:main Dec 2, 2022
@kevindass
Copy link
Owner

I did clone the repo post your PR commit. However I still get the below

My Launchpad site URL is
https://86a9c654trial.launchpad.cfapps.ap21.hana.ondemand.com/site?siteId=2c369f17-05af-4276-a234-c85e93df2996#demo-reqres?sap-ui-app-id-hint=saas_approuter_reqres

image
image

@nicoschoenteich
Copy link
Contributor Author

Ok, I see. Try accessing the application directly from the HTML5 Application tab in the BTP Cockpit instead of the Fiori Launchpad:
Screenshot 2022-12-02 at 13 18 36

The whole myPathWithoutFile thing only works in that scenario. I'll have to find out how to elegantly do this from within the Fiori Launchpad...

@kevindass
Copy link
Owner

@nicoschoenteich ok!!! that works. Question, what does this mean ?

  1. Launchpad service with managed app router doesn't yet support REST API destination ?
  2. If that is true, then SAPUI5 app based on REST API should be hosted with standalone app router ?

Your thoughts?

@nicoschoenteich
Copy link
Contributor Author

Hi @kevindass,
I'm glad it works!
I do believe the scenario we are trying to build here can work in the Fiori Launchpad. Probably some minor thing we are missing. I will do some research.
Best, Nico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants