Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rest call from within fiori launchpad #2

Merged
merged 1 commit into from Dec 21, 2022
Merged

fix: rest call from within fiori launchpad #2

merged 1 commit into from Dec 21, 2022

Conversation

nicoschoenteich
Copy link
Contributor

Hi @kevindass, I found a solution to the problem. If we properly define the rest endpoint as a data source and the corresponding json model in the manifest.json, we can consume the model in our view regardless of the environment (meaning local, BAS, standalone CF, Fiori Launchpad).

It's now working from within the Launchpad, too:
Screenshot 2022-12-02 at 14 42 52

Turns out tinkering with the ajax call manually wasn't the best approach...

@kevindass
Copy link
Owner

Thank you @nicoschoenteich

@kevindass kevindass merged commit 8c1c56f into kevindass:main Dec 21, 2022
@kevindass
Copy link
Owner

@nicoschoenteich
Could you help me to understand this solution provided:
In mta.yaml, the addition of “destinations” with name “reqres” would create new destination under “Service Instance: reqres-destination-service - Destinations”.
Question: Does adding “destinations” with name “reqres” of URL means we are hard coding API endpoint into mta.ymal or it would still use “destinations” created at sun-account level ”Connectivity->Destinations” with help of xs-app.json?

image
image

@nicoschoenteich
Copy link
Contributor Author

nicoschoenteich commented Jan 2, 2023

Hi @kevindass,
Yes, you are right. We are hardcoding the endpoint for the destination in the mta.yaml in this case, but this doesn't mean we couldn't create another subaccount or instance level destination. We can create as many destinations with unique names as we like.
Best, Nico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants