Return event instead of keyCode #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badaz
commented
Nov 24, 2017
| public List<Class<? extends JavaScriptModule>> createJSModules() { | ||
| return Collections.emptyList(); | ||
| } | ||
|
|
There was a problem hiding this comment.
I also added this for compatibility with older versions of RN
|
This looks good to me. I appreciate the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for this module, I had to use it in a project an I found that it lacked the possibility to get more from the event than just the keyCode, therefore I modified it a little so that it returns an event containing the keyCode, the action and the characters in case of a keyCode UNKNOW + action MULTIPLE. I also added a listener on onKeyMultiple.
I know it is breaking and I'm sorry about that. One possibility would be to add a param to the onKeyXXXListener methods to get an event instead of just the keyCode.