Fix isValidTimeZone under MacOS X #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix. I don't have a Mac so I would have never known. |
kevinkhill
added a commit
that referenced
this pull request
Jun 28, 2017
Fix isValidTimeZone under MacOS X
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my MacOS X PHP 7.0.19 the call to date_default_timezone_get() returns etc/UTC but the isValidTimeZone function uses in_array to search for the timezone but as this is a string in_array does a case sensitive search which fails as PHP reports this timezone as etc/UTC.