Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle null URL in navigation/menu models #111

Merged
merged 2 commits into from
Sep 14, 2022
Merged

handle null URL in navigation/menu models #111

merged 2 commits into from
Sep 14, 2022

Conversation

kevinpapst
Copy link
Owner

Description

fixes #110

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I updated the documentation (see here)
  • I agree that this code will be published under the MIT license

@kevinpapst kevinpapst added the Bug Something isn't working label Sep 13, 2022
@cavasinf
Copy link
Collaborator

Does it works with user menu ? (top bar nav)
image

@cavasinf cavasinf added the Status: Reviewed Has staff reply/investigation label Sep 14, 2022
@kevinpapst
Copy link
Owner Author

You have weird use-cases 😁 but you are correct, it wasn't possible ... fixed with the latest commit!

@cavasinf
Copy link
Collaborator

You have weird use-cases 😁 but you are correct, it wasn't possible ... fixed with the latest commit!

Just looked where MenuItemModel is used 😉

cavasinf
cavasinf approved these changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@cavasinf cavasinf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kevinpapst kevinpapst merged commit 94e964c into main Sep 14, 2022
@kevinpapst kevinpapst deleted the empty-url branch September 14, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cavasinf cavasinf cavasinf approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Status: Reviewed Has staff reply/investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu item allows null route name but not when rendered
2 participants
@kevinpapst @cavasinf