-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alert] Add id
and attr
option
#156
Conversation
Should we remove the |
Yes, remove the deprecated stuff. I know you like the better readability of multiline HTML. What just came to my mind while reading your changes: we could merge |
Done ✔️
Yes I do 😉 And I do it without noticing it now, sorry 😅
Good idea! Done ✔️
Funny, because I was thinking about that when I added those new params. |
Talking about things to change.
Has its place in the bundle. WDYT ? We can deprecate it like that: {% if (_title is empty or _description is empty) and options.important is not defined %}
{% deprecated "Using important alert without setting the 'important' option is deprecated, set option to true instead." %}
{% set _important = true %}
{% endif %} |
Where do I find I had recently troubles showing an alert notification in a certain way. Maybe that was the reason... |
There:
|
Any update on that @kevinpapst? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works 👍 merge 🚀
Thanks!
Description
Adds
id
andattr
optionTypes of changes
Checklist