Skip to content

Commit

Permalink
vhost: support selective datapath
Browse files Browse the repository at this point in the history
This patch set introduces support for selective datapath in DPDK vhost-user
lib. vDPA stands for vhost Data Path Acceleration. The idea is to support
virtio ring compatible devices to serve virtio driver directly to enable
datapath acceleration.

A set of device ops is defined for device specific operations:

     a. get_queue_num: Called to get supported queue number of the device.

     b. get_features: Called to get supported features of the device.

     c. get_protocol_features: Called to get supported protocol features of
        the device.

     d. dev_conf: Called to configure the actual device when the virtio
        device becomes ready.

     e. dev_close: Called to close the actual device when the virtio device
        is stopped.

     f. set_vring_state: Called to change the state of the vring in the
        actual device when vring state changes.

     g. set_features: Called to set the negotiated features to device.

     h. migration_done: Called to allow the device to response to RARP
        sending.

     i. get_vfio_group_fd: Called to get the VFIO group fd of the device.

     j. get_vfio_device_fd: Called to get the VFIO device fd of the device.

     k. get_notify_area: Called to get the notify area info of the queue.

Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
  • Loading branch information
johnakawzh authored and Ferruh Yigit committed Apr 13, 2018
1 parent 2e28f45 commit d7280c9
Show file tree
Hide file tree
Showing 5 changed files with 215 additions and 5 deletions.
4 changes: 2 additions & 2 deletions lib/librte_vhost/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev -lrte_net

# all source are stored in SRCS-y
SRCS-$(CONFIG_RTE_LIBRTE_VHOST) := fd_man.c iotlb.c socket.c vhost.c \
vhost_user.c virtio_net.c
vhost_user.c virtio_net.c vdpa.c

# install includes
SYMLINK-$(CONFIG_RTE_LIBRTE_VHOST)-include += rte_vhost.h
SYMLINK-$(CONFIG_RTE_LIBRTE_VHOST)-include += rte_vhost.h rte_vdpa.h

include $(RTE_SDK)/mk/rte.lib.mk
7 changes: 4 additions & 3 deletions lib/librte_vhost/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ if has_libnuma == 1
endif
version = 4
allow_experimental_apis = true
sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vhost.c', 'vhost_user.c',
sources = files('fd_man.c', 'iotlb.c', 'socket.c', 'vdpa.c',
'vhost.c', 'vhost_user.c',
'virtio_net.c')
headers = files('rte_vhost.h')
deps += ['ethdev']
headers = files('rte_vhost.h', 'rte_vdpa.h')
deps += ['ethdev', 'pci']
87 changes: 87 additions & 0 deletions lib/librte_vhost/rte_vdpa.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
/* SPDX-License-Identifier: BSD-3-Clause
* Copyright(c) 2018 Intel Corporation
*/

#ifndef _RTE_VDPA_H_
#define _RTE_VDPA_H_

/**
* @file
*
* Device specific vhost lib
*/

#include <rte_pci.h>
#include "rte_vhost.h"

#define MAX_VDPA_NAME_LEN 128

enum vdpa_addr_type {
PCI_ADDR,
VDPA_ADDR_MAX
};

struct rte_vdpa_dev_addr {
enum vdpa_addr_type type;
union {
uint8_t __dummy[64];
struct rte_pci_addr pci_addr;
};
};

struct rte_vdpa_dev_ops {
/* Get capabilities of this device */
int (*get_queue_num)(int did, uint32_t *queue_num);
int (*get_features)(int did, uint64_t *features);
int (*get_protocol_features)(int did, uint64_t *protocol_features);

/* Driver configure/close the device */
int (*dev_conf)(int vid);
int (*dev_close)(int vid);

/* Enable/disable this vring */
int (*set_vring_state)(int vid, int vring, int state);

/* Set features when changed */
int (*set_features)(int vid);

/* Destination operations when migration done */
int (*migration_done)(int vid);

/* Get the vfio group fd */
int (*get_vfio_group_fd)(int vid);

/* Get the vfio device fd */
int (*get_vfio_device_fd)(int vid);

/* Get the notify area info of the queue */
int (*get_notify_area)(int vid, int qid,
uint64_t *offset, uint64_t *size);

/* Reserved for future extension */
void *reserved[5];
};

struct rte_vdpa_device {
struct rte_vdpa_dev_addr addr;
struct rte_vdpa_dev_ops *ops;
} __rte_cache_aligned;

/* Register a vdpa device, return did if successful, -1 on failure */
int __rte_experimental
rte_vdpa_register_device(struct rte_vdpa_dev_addr *addr,
struct rte_vdpa_dev_ops *ops);

/* Unregister a vdpa device, return -1 on failure */
int __rte_experimental
rte_vdpa_unregister_device(int did);

/* Find did of a vdpa device, return -1 on failure */
int __rte_experimental
rte_vdpa_find_device_id(struct rte_vdpa_dev_addr *addr);

/* Find a vdpa device based on did */
struct rte_vdpa_device * __rte_experimental
rte_vdpa_get_device(int did);

#endif /* _RTE_VDPA_H_ */
7 changes: 7 additions & 0 deletions lib/librte_vhost/rte_vhost_version.map
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,10 @@ DPDK_18.02 {
rte_vhost_vring_call;

} DPDK_17.08;

EXPERIMENTAL {
rte_vdpa_register_device;
rte_vdpa_unregister_device;
rte_vdpa_find_device_id;
rte_vdpa_get_device;
} DPDK_18.02;
115 changes: 115 additions & 0 deletions lib/librte_vhost/vdpa.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,115 @@
/* SPDX-License-Identifier: BSD-3-Clause
* Copyright(c) 2018 Intel Corporation
*/

/**
* @file
*
* Device specific vhost lib
*/

#include <stdbool.h>

#include <rte_malloc.h>
#include "rte_vdpa.h"
#include "vhost.h"

static struct rte_vdpa_device *vdpa_devices[MAX_VHOST_DEVICE];
static uint32_t vdpa_device_num;

static bool
is_same_vdpa_device(struct rte_vdpa_dev_addr *a,
struct rte_vdpa_dev_addr *b)
{
bool ret = true;

if (a->type != b->type)
return false;

switch (a->type) {
case PCI_ADDR:
if (a->pci_addr.domain != b->pci_addr.domain ||
a->pci_addr.bus != b->pci_addr.bus ||
a->pci_addr.devid != b->pci_addr.devid ||
a->pci_addr.function != b->pci_addr.function)
ret = false;
break;
default:
break;
}

return ret;
}

int
rte_vdpa_register_device(struct rte_vdpa_dev_addr *addr,
struct rte_vdpa_dev_ops *ops)
{
struct rte_vdpa_device *dev;
char device_name[MAX_VDPA_NAME_LEN];
int i;

if (vdpa_device_num >= MAX_VHOST_DEVICE)
return -1;

for (i = 0; i < MAX_VHOST_DEVICE; i++) {
dev = vdpa_devices[i];
if (dev && is_same_vdpa_device(&dev->addr, addr))
return -1;
}

for (i = 0; i < MAX_VHOST_DEVICE; i++) {
if (vdpa_devices[i] == NULL)
break;
}

sprintf(device_name, "vdpa-dev-%d", i);
dev = rte_zmalloc(device_name, sizeof(struct rte_vdpa_device),
RTE_CACHE_LINE_SIZE);
if (!dev)
return -1;

memcpy(&dev->addr, addr, sizeof(struct rte_vdpa_dev_addr));
dev->ops = ops;
vdpa_devices[i] = dev;
vdpa_device_num++;

return i;
}

int
rte_vdpa_unregister_device(int did)
{
if (did < 0 || did >= MAX_VHOST_DEVICE || vdpa_devices[did] == NULL)
return -1;

rte_free(vdpa_devices[did]);
vdpa_devices[did] = NULL;
vdpa_device_num--;

return did;
}

int
rte_vdpa_find_device_id(struct rte_vdpa_dev_addr *addr)
{
struct rte_vdpa_device *dev;
int i;

for (i = 0; i < MAX_VHOST_DEVICE; ++i) {
dev = vdpa_devices[i];
if (dev && is_same_vdpa_device(&dev->addr, addr))
return i;
}

return -1;
}

struct rte_vdpa_device *
rte_vdpa_get_device(int did)
{
if (did < 0 || did >= MAX_VHOST_DEVICE)
return NULL;

return vdpa_devices[did];
}

0 comments on commit d7280c9

Please sign in to comment.