Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video support via youtube-dl #74

Merged
merged 6 commits into from
Jun 24, 2020
Merged

Video support via youtube-dl #74

merged 6 commits into from
Jun 24, 2020

Conversation

krzygorz
Copy link
Contributor

This adds basic support for video posts via youtube-dl with a fallback to an alternative extractor for low-quality mobile versions of the videos.

Some notes:

  • This asks youtube-dl for a single link of highest possible quality. I think it's possible to get a slightly better result by merging separate video and audio files but then we'd have to download the files instead of just returning an url.
  • youtube-dl is added to pyproject.toml as an optional dependency
  • youtube-dl is turned on by passing youtube_dl=True to get_posts, I'm not sure if this is an optimal choice.

@kevinzg
Copy link
Owner

kevinzg commented Jun 24, 2020

Awesome, thanks for your contribution!

@kevinzg kevinzg merged commit cb7bbe4 into kevinzg:master Jun 24, 2020
@kevinzg kevinzg mentioned this pull request Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants