Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

feat: support dotenv vars to set up credentials and projectId #69

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

HelderSi
Copy link
Contributor

@HelderSi HelderSi commented Oct 17, 2022

Hi,

first of all, thanks for this amazing project. It's helping me a lot.

I opened this PR to add support to .env vars using dotenv lib. I think it's very useful, especially, in the development environment.

Dotenv is a well-known lib to storing environment variables. Supporting .env vars file on fireway we don't need to manually export credentials var or pass projectId option on cli, we can set fireway vars on the same file(.env) we are used to using, and it makes cli migrate command less verbose.

The vars that this feature uses are:

GOOGLE_PROJECT_ID=project-id
GOOGLE_APPLICATION_CREDENTIALS=path/to/googe-service-account.json

Doing so we can run fireway migrate command without --projectId option and we don't need to run export GOOGLE_APPLICATION_CREDENTIALS="path/to/googe-service-account.json" on the terminal.

I hope this helps other devs as helped me.

@HelderSi
Copy link
Contributor Author

Hi.

Any notes about this PR?

tks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant