This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
feat: support dotenv vars to set up credentials and projectId #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all, thanks for this amazing project. It's helping me a lot.
I opened this PR to add support to .env vars using dotenv lib. I think it's very useful, especially, in the development environment.
Dotenv is a well-known lib to storing environment variables. Supporting .env vars file on fireway we don't need to manually export credentials var or pass projectId option on cli, we can set fireway vars on the same file(.env) we are used to using, and it makes cli migrate command less verbose.
The vars that this feature uses are:
Doing so we can run
fireway migrate
command without--projectId
option and we don't need to runexport GOOGLE_APPLICATION_CREDENTIALS="path/to/googe-service-account.json"
on the terminal.I hope this helps other devs as helped me.