fix: Debitor ids are optional for transfers #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippertto
commented
Nov 24, 2023
kewisch
approved these changes
Nov 25, 2023
kewisch
force-pushed
the
optional-debtor-id
branch
from
d090026
to
76d7055
Compare
|
Force push was to test the new CI, seems to work :) |
lippertto
force-pushed
the
optional-debtor-id
branch
from
76d7055
to
52136f8
Compare
|
Great, thanks for the hint on the default values. The code looks much nicer now 👍 I updated the code to use the destructuring, and from my point of view the PR is ready to be merged. |
kewisch
reviewed
Nov 27, 2023
Also: Actually include the creditor/debitor ids when they are set Fixes #58
lippertto
force-pushed
the
optional-debtor-id
branch
from
52136f8
to
d1284aa
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: Actually include the creditor/debitor ids when they are set
Fixes #58