Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image size isn't always preserved properly #18

Closed
nothings opened this issue Jan 29, 2023 · 3 comments
Closed

image size isn't always preserved properly #18

nothings opened this issue Jan 29, 2023 · 3 comments

Comments

@nothings
Copy link
Collaborator

nothings commented Jan 29, 2023

It wrote out the image at 512x512, which was also the tile size and which I assume is not a coincidence, but I don't know the cause. If I wan't in the middle of face detection stuff I'd track it down myself.

Note this causes weird stretching of the image. Only happened on some images and not others. Does happen when running this image by itself.

This wasn't happening with the old version from before the compositing change, and I verified this is happening on the current code without my modifications.

Input:
00484-916853272- the convention floor  at comiccon_0 1  __28yo women with innocent and gorgeous faces and perfect skin  (on the convention floor

Output:
00030--1 0-

(I know this is a terrible image, I had bad hires fix settings when I made the original. It's part of my face detection test set because of the blurry faces in the background. And the face swapped version was just a quick test that ran for 5 steps.)

@nothings
Copy link
Collaborator Author

nothings commented Jan 29, 2023

Possibly all my other test cases that didn't break had 0 or 2+ faces, and the issue is on the special path for handling 1 face.

kex0 added a commit that referenced this issue Jan 29, 2023
@kex0
Copy link
Owner

kex0 commented Jan 29, 2023

No matter what I did I couldn't replicate this, unless I used this option.

chrome_H8KDGnuEdx

With latest commit I force this to be at "Only masked" maybe that will fix it?

@nothings
Copy link
Collaborator Author

nothings commented Jan 29, 2023

Oh god, yeah, I thought that was being ignored, I usually set it just in case. But I'd been fixing the UI for my merge which means I have to keep reloading the web page and resetting everything. My bad! But making it force it on is probably good anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants