Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followed person with revoked proof shows confusing interface #15899

Open
lilyball opened this issue Feb 5, 2019 · 0 comments
Open

Followed person with revoked proof shows confusing interface #15899

lilyball opened this issue Feb 5, 2019 · 0 comments

Comments

@lilyball
Copy link

lilyball commented Feb 5, 2019

Someone I follow apparently revoked one of their proofs some time ago. In the desktop client, their name shows as red, and when I click on them their profile header has a red background, but other than that, there's nothing to explain that they revoked a proof. For comparison, the mobile client has the text "Some of $name's proofs are broken.", though this seems misleading as it appears that they deleted their PGP key proof and all the proofs on their profile right now are valid. Also for comparison, the website doesn't indicate anything at all is wrong with my follow of this profile.

In addition to the unexplained red, the desktop and mobile clients also offer "Refresh" and "Accept" buttons, with no explanation as to what this means. I'm assuming that "Refresh" means "re-check the proofs" and "Accept" means "update my follow for their current set of proofs", but I'm really not sure. Tapping "Refresh" has zero feedback whatsoever so it's hard to tell if it's actually doing anything at all.

After writing all that, I finally went ahead and clicked "Accept" in the desktop client and still nothing at all happened. So then I clicked "Accept" in the mobile client and the entire profile was replaced with the text

Error loading profile: There was an error:
Following statement was stale

Closing and reopening the profile continued to show this error. I finally force-quit the app and relaunched it, and now the profile appears green, and keybase id $name on the CLI indicates that I did in fact re-follow the user. The desktop client continues to show the red banner and Refresh/Accept buttons though, I had to completely quit it (including the status bar item) before it would reload the profile properly.

Ultimately there are several issues here:

  1. The desktop client shows a red username / red header with no description as to what's going on.
  2. The mobile client has a misleading description as to what's going on (this person's proofs aren't broken, they simply revoked one of the proofs from my follow statement).
  3. Both desktop and mobile clients have a mysterious "Refresh" button that appears to do nothing.
  4. Both desktop and mobile clients have a mysterious "Accept" button". On desktop it appears to do nothing. On mobile I guess it worked but it produced an error. Either that or on desktop it worked (but didn't update the UI) and then on mobile it broke because I had already re-followed elsewhere. Not entirely sure.
  5. Both desktop and mobile clients refuse to refresh the profile without fully quitting and relaunching.
  6. Desktop and mobile clients have no indication whatsoever as to what proofs were tracked, which means there's no explanation as to what proofs were revoked from my follow statement.
  7. Web doesn't even attempt to show when a follow statement is broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant