Suspend inbox loading on sends #14732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaxim
requested changes
Nov 16, 2018
joshblum
force-pushed
the
joshblum/cancel-CORE-9432
branch
2 times, most recently
from
8714714
to
93b194a
Compare
|
@mmaxim updated ptal! |
mmaxim
reviewed
Nov 21, 2018
go/chat/utils/utils.go
Outdated
| @@ -1660,3 +1660,16 @@ func SetUnfurl(mvalid *chat1.MessageUnboxedValid, unfurlMessageID chat1.MessageI | |||
| } | |||
| mvalid.Unfurls[unfurlMessageID] = unfurl | |||
| } | |||
|
|
|||
| // SuspendComponent will suspend the global ConvLoader until the return | |||
There was a problem hiding this comment.
Suspends any Suspendable, not just ConvLoader
mmaxim
approved these changes
Nov 21, 2018
joshblum
force-pushed
the
joshblum/cancel-CORE-9432
branch
from
93b194a
to
aa1028f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suspend inbox loads when sending any messages as a potential optimization of the send path. It seems like the machinery was already in place, were there any other places we should be calling this?