Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type ids exposed by the api #21975

Merged
merged 7 commits into from Jan 15, 2020
Merged

type ids exposed by the api #21975

merged 7 commits into from Jan 15, 2020

Conversation

@joshblum
Copy link
Member

joshblum commented Jan 9, 2020

No description provided.

@joshblum joshblum requested a review from mmaxim Jan 9, 2020
@joshblum joshblum mentioned this pull request Jan 9, 2020
@joshblum joshblum force-pushed the joshblum/api-types-HOTPOT-1652 branch from d1b2aa2 to 9d9be38 Jan 10, 2020
@mmaxim

This comment has been minimized.

Copy link
Contributor

mmaxim commented Jan 13, 2020

Could drop something like type ConversationIDStr = string in there

@joshblum joshblum force-pushed the joshblum/api-types-HOTPOT-1652 branch 2 times, most recently from 9963a93 to a141d8c Jan 13, 2020
@joshblum

This comment has been minimized.

Copy link
Member Author

joshblum commented Jan 14, 2020

(ci flake unrelated)

@joshblum joshblum force-pushed the joshblum/api-types-HOTPOT-1652 branch from a141d8c to d4fe783 Jan 14, 2020
@joshblum joshblum force-pushed the joshblum/api-types-HOTPOT-1652 branch from 57ac9f9 to 6aba56a Jan 14, 2020
@mmaxim
mmaxim approved these changes Jan 14, 2020
@joshblum joshblum merged commit a829f67 into master Jan 15, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details
@joshblum joshblum deleted the joshblum/api-types-HOTPOT-1652 branch Jan 15, 2020
maxtaco added a commit that referenced this pull request Jan 15, 2020
This reverts commit a829f67.
maxtaco added a commit that referenced this pull request Jan 15, 2020
This reverts commit a829f67.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.