Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kbfuse 4.0.5 #24378

Merged
merged 21 commits into from
Jan 15, 2021
Merged

kbfuse 4.0.5 #24378

merged 21 commits into from
Jan 15, 2021

Conversation

songgao
Copy link
Contributor

@songgao songgao commented Dec 2, 2020

@songgao songgao requested review from mmaxim and strib December 2, 2020 00:30
@songgao songgao marked this pull request as draft December 2, 2020 00:30
@songgao songgao changed the title [wip] kbfuse 4.0.4 kbfuse 4.0.4 Dec 2, 2020
Copy link
Contributor

@strib strib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, assuming you've been able to test it successfully!

osx/Fuse/build.sh Outdated Show resolved Hide resolved
osx/Installer/Info.plist Outdated Show resolved Hide resolved
@kg4zow
Copy link

kg4zow commented Dec 12, 2020

I tried to build from this branch (my first time building Keybase from source), ran into an issue in the pod install command. Full error report is at /keybase/public/jms1/notes/keybase-build-error.txt, but the the relevant error message is...

LoadError - dlopen(/Library/Ruby/Gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle, 0x0009): missing compatible arch in /Library/Ruby/Gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle - /Library/Ruby/Gems/2.6.0/gems/ffi-1.13.1/lib/ffi_c.bundle

I've heard the term "Cocoa Pods" before but I know nothing about it ... most of my programming for the past 5+ years has been Linux server stuff, in Perl and Puppet, but I've been programming in C for ... almost 34 years now? (I feel so old when I say that...)

Hopefully this will turn out to be a known issue, I haven't stared reading through the three possible github matches yet, I'll dig into that tomorrow. Feel free to reach out on Keybase chat if needed.

@songgao songgao changed the title kbfuse 4.0.4 kbfuse 4.0.5 Jan 4, 2021
}
return YES;
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the workaround if someone wants to take a second look

@songgao songgao marked this pull request as ready for review January 15, 2021 16:20
@songgao songgao merged commit cd76ccb into master Jan 15, 2021
@songgao songgao deleted the songgao/ZCLIENT-951 branch January 15, 2021 16:20
songgao added a commit that referenced this pull request Jan 22, 2021
@billinghamj
Copy link

Is this likely to come back at any point? I see it was reverted. Understand it's not really a supported product any more, don't want to add any pressure :)

songgao added a commit that referenced this pull request Jan 29, 2021
* kbfuse 4.0.4

* bump installer version to use kbfuse 4.0.4

* update README.md

* use the new build command

* strib feedback

* new installer

* update bazil fuse

* update kext identifier

* uninstall using both old and new kext ID

* Revert "uninstall using both old and new kext ID"

This reverts commit 5216375.

* Revert "update kext identifier"

This reverts commit dab445d.

* just change the kbfuse identifier back

* fix redirector mounting

* update fuse vendor to master commit

* new installer version built  with xcode12.3beta

* macFuse 4.0.5

* update bazil/fuse vendor for better error handling

* bump helper/installer version

* helper: fall back to kmutil for kext unload on macOS 11

* ahhhhhhhhhhhh

* update helper prompt text

Co-authored-by: Mike Maxim <mike.maxim@zoom.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants