-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kbfuse 4.0.5 #24378
kbfuse 4.0.5 #24378
Conversation
songgao
commented
Dec 2, 2020
•
edited
Loading
edited
- build and upload the Installer
- merge use the "new style" for getting device fd from macfuse fuse#3 and update the vendor hash here
- implement proper error handling in bazil/fuse (call umount if error happens during mounting fuse#4) and update vendor here
- fix helper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall, assuming you've been able to test it successfully!
I tried to build from this branch (my first time building Keybase from source), ran into an issue in the
I've heard the term "Cocoa Pods" before but I know nothing about it ... most of my programming for the past 5+ years has been Linux server stuff, in Perl and Puppet, but I've been programming in C for ... almost 34 years now? (I feel so old when I say that...) Hopefully this will turn out to be a known issue, I haven't stared reading through the three possible github matches yet, I'll dig into that tomorrow. Feel free to reach out on Keybase chat if needed. |
} | ||
return YES; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the workaround if someone wants to take a second look
373fea3
to
be961d3
Compare
Is this likely to come back at any point? I see it was reverted. Understand it's not really a supported product any more, don't want to add any pressure :) |
* kbfuse 4.0.4 * bump installer version to use kbfuse 4.0.4 * update README.md * use the new build command * strib feedback * new installer * update bazil fuse * update kext identifier * uninstall using both old and new kext ID * Revert "uninstall using both old and new kext ID" This reverts commit 5216375. * Revert "update kext identifier" This reverts commit dab445d. * just change the kbfuse identifier back * fix redirector mounting * update fuse vendor to master commit * new installer version built with xcode12.3beta * macFuse 4.0.5 * update bazil/fuse vendor for better error handling * bump helper/installer version * helper: fall back to kmutil for kext unload on macOS 11 * ahhhhhhhhhhhh * update helper prompt text Co-authored-by: Mike Maxim <mike.maxim@zoom.us>