visdiff: Use HEAD instead of $TRAVIS_COMMIT #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that $TRAVIS_COMMIT can fall out of date wrt GitHub's merged PR ref in some cases, which breaks visdiff because the commit it tries to check out doesn't exist.
|
Can one of the admins verify this patch? |
|
👍 |
|
🔎 No visual changes found as a result of these commits. |
|
Oops, spotted while sanity checking the Travis output: we need to determine the value of |
|
🔎 No visual changes found as a result of these commits. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that $TRAVIS_COMMIT can fall out of date wrt GitHub's merged PR
ref in some cases, which breaks visdiff because the commit it tries to
check out doesn't exist.
👓 @keybase/react-hackers