Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rekey convo list - fixup messed up merge #5658

Merged
merged 14 commits into from
Feb 3, 2017

Conversation

chrisnojima
Copy link
Contributor

@chrisnojima chrisnojima commented Feb 3, 2017

@keybase/react-hackers This is essentially a replacement for #5606. I had a bunch of branch off of branch and merged in a not-ideal order. So i fixed this thing up and remade it work vs master.

@chromakode already approved the previous one so if you review its mostly a sanity check. I did up the icon so the code is a tiny bit different (couple of lines)

@keybase-ci-visdiff
Copy link

The commits 3707123...836a42e introduce visual changes on linux.

🔎 3 new, 3 changed

  • Added: You_Rekey-Normal
    You_Rekey-Normal rendered
  • Added: Chat_Conversations_List-You_Rekey_Selected
    Chat_Conversations_List-You_Rekey_Selected rendered
  • Added: Chat_Conversations_List-You_Rekey
    Chat_Conversations_List-You_Rekey rendered
  • Changed: Chat_Participant_Rekey-Normal (before) (after)
    Chat_Participant_Rekey-Normal comparison
  • Changed: Chat_Conversations_List-Part_Rekey_Selected (before) (after)
    Chat_Conversations_List-Part_Rekey_Selected comparison
  • Changed: Chat_Conversations_List-Part_Rekey (before) (after)
    Chat_Conversations_List-Part_Rekey comparison

@keybase-ci-visdiff
Copy link

The commits 3707123...43ade7e introduce visual changes on linux.

🔎 3 new, 3 changed

  • Added: You_Rekey-Normal
    You_Rekey-Normal rendered
  • Added: Chat_Conversations_List-You_Rekey_Selected
    Chat_Conversations_List-You_Rekey_Selected rendered
  • Added: Chat_Conversations_List-You_Rekey
    Chat_Conversations_List-You_Rekey rendered
  • Changed: Chat_Participant_Rekey-Normal (before) (after)
    Chat_Participant_Rekey-Normal comparison
  • Changed: Chat_Conversations_List-Part_Rekey_Selected (before) (after)
    Chat_Conversations_List-Part_Rekey_Selected comparison
  • Changed: Chat_Conversations_List-Part_Rekey (before) (after)
    Chat_Conversations_List-Part_Rekey comparison

@chrisnojima chrisnojima changed the title WIP wait rekey convo list - fixup messed up merge rekey convo list - fixup messed up merge Feb 3, 2017
@keybase-ci-visdiff
Copy link

The commits 3707123...56bd5db introduce visual changes on linux.

🔎 3 new, 4 changed

  • Added: You_Rekey-Normal
    You_Rekey-Normal rendered
  • Added: Chat_Conversations_List-You_Rekey_Selected
    Chat_Conversations_List-You_Rekey_Selected rendered
  • Added: Chat_Conversations_List-You_Rekey
    Chat_Conversations_List-You_Rekey rendered
  • Changed: Icon-Icon_Image (before) (after)
    Icon-Icon_Image comparison
  • Changed: Chat_Participant_Rekey-Normal (before) (after)
    Chat_Participant_Rekey-Normal comparison
  • Changed: Chat_Conversations_List-Part_Rekey_Selected (before) (after)
    Chat_Conversations_List-Part_Rekey_Selected comparison
  • Changed: Chat_Conversations_List-Part_Rekey (before) (after)
    Chat_Conversations_List-Part_Rekey comparison

@chromakode chromakode self-requested a review February 3, 2017 19:43
@chromakode chromakode merged commit e35b8d7 into master Feb 3, 2017
@chromakode chromakode deleted the nojima/DESKTOP-wait-rekey-convo-list branch February 3, 2017 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants