Visual tweaks #5672
Merged
Visual tweaks #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keybase/react-hackers |
chromakode
approved these changes
Feb 6, 2017
| @@ -9,7 +9,7 @@ import type {Props} from './header' | |||
| const Header = ({participants, onOpenFolder, onToggleSidePanel, sidePanelOpen, you, metaDataMap, followingMap, onShowProfile}: Props) => ( | |||
| <Box style={containerStyle}> | |||
| <Usernames colorFollowing={true} inline={false} commaColor={globalColors.black_40} type='BodyBig' users={usernamesToUserListItem(participantFilter(participants, you).toArray(), you, metaDataMap, followingMap)} | |||
| containerStyle={{flex: 1, textAlign: 'center', justifyContent: 'center'}} onUsernameClicked={onShowProfile} /> | |||
| containerStyle={{flex: 1, textAlign: 'center', justifyContent: 'center', marginLeft: 48}} onUsernameClicked={onShowProfile} /> | |||
There was a problem hiding this comment.
Would globalMargins.large be appropriate here instead of 48?
There was a problem hiding this comment.
Hmm, no globalMargins.large is 40px, not 48. This tweak is to recenter the usernames in the header by pushing them by 2 times 24 (from both icons on the right side).
| @@ -139,7 +139,7 @@ class Avatar extends Component<void, Props, State> { | |||
| {this.props.backgroundColor && | |||
| <div | |||
| style={{...avatarStyle, | |||
| ...borderStyle, | |||
There was a problem hiding this comment.
Looks like this removes the logic that handles a this.props.borderColor passed in to the component. I don't see it being used anywhere, so you can probably delete the const borderStyle = this.props.borderColor ? {borderRadius... line too.
There was a problem hiding this comment.
Max and I chatted live about this - the borderColor attribute is used in the nav bar so we're keeping it.
| {badgeNumber > 0 && | ||
| <Box style={{...styleBadgeNav}}> | ||
| <Badge badgeNumber={badgeNumber} badgeStyle={{marginLeft: 0, marginRight: 0}} /> | ||
| <Badge badgeNumber={badgeNumber} badgeStyle={{marginLeft: 0, marginRight: 8}} outlineColor={globalColors.midnightBlue} /> |
chromakode
approved these changes
Feb 6, 2017
|
The commits 92afd2a...045ebed introduce visual changes on linux. 🔎 7 new, 19 changed
|
|
The commits 92afd2a...045ebed introduce visual changes on linux. 🔎 7 new, 19 changed
|
|
The commits 1f9d0f5...bc853b7 introduce visual changes on linux. 🔎 7 new, 19 changed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.