Support opening a new chat from the Folders tab #5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisnojima
requested changes
Feb 6, 2017
shared/actions/chat.js
Outdated
| @@ -1173,6 +1178,12 @@ function _unboxedToMessage (message: MessageUnboxed, idx: number, yourName, your | |||
| } | |||
| } | |||
|
|
|||
| function * _openTlfInChat (action: OpenTlfInChat): SagaGenerator<any, any> { | |||
| const tlf = action.payload | |||
| const users = tlf.split(',') | |||
There was a problem hiding this comment.
you should use the kbfs helpers to do this
|
@chrisnojima Thanks, fixed that, also now checks to see whether there are any readers (e.g. |
chrisnojima
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keybase/react-hackers
This PR adds two new buttons: A "Chat" button to each row in the main folders tab view of rows, and an "Open in chat" button inside the per-folder view.
Our startConversation() action takes a list of users (and is fine to call on an existing conversation), so we just take the TLF name from
folder.sortName(e.g. cjb,chrisnojima,max) and calltlf.split(',')to get the users array.The chat buttons are only shown on private folders, not public ones. No implementation for mobile yet.