New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation list mobile #5813
Merged
chrisnojima
merged 7 commits into
nojima/DESKTOP-rn-fixes-4
from
nojima/DESKTOP-conversation-list-mobile
Feb 14, 2017
Merged
Conversation list mobile #5813
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
750eefd
usernames working
chrisnojima e096501
bottom line working
chrisnojima f628a14
WIP
chrisnojima 9109985
Merge branch 'nojima/DESKTOP-rn-fixes-4' into nojima/DESKTOP-conversa…
chrisnojima dd06168
fixup merge
chrisnojima a9eb9bc
fix overflow on row bottom
chrisnojima 4137526
pr fixes
chrisnojima File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,10 +8,10 @@ import {envVarDebugJson, isTesting} from './local-debug' | |
|
||
// Shared settings | ||
const dumbFilterJson = (envVarDebugJson() || {}).dumbFilter || '' | ||
const dumbFilterOverride = '' // Changing this will apply during a hot reload session | ||
const dumbFilterOverride = 'conversations' // Changing this will apply during a hot reload session | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✂️ |
||
|
||
export const dumbFilter = dumbFilterOverride || dumbFilterJson | ||
|
||
// Mobile only settings | ||
export const dumbIndex = 0 | ||
export const dumbIndex = 9 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✂️ |
||
export const dumbFullscreen = isTesting |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent