mount_linux: implement hanwen's poll hack for fixing test deadlock #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea for this fix, and most of the code from it, should be credited to hanwen, from commit 4f10e248e of the hanwen/go-fuse repo. Briefly, on Linux, when the same process that's serving a fuse mountpoint is sending epoll requests to that mountpoint (as is common in tests), the go runtime can deadlock. This works around the issue with a nasty hack that forces the kernel to learn (and cache) the fact that polling is not implemented right after the mount happens, to avoid deadlocks when the test later makes the same request. Issue: golang/go#21014 Issue: hanwen/go-fuse#165 Issue: bazil#183
jzila
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea for this fix, and most of the code from it, should be credited to hanwen, from commit 4f10e248e of the hanwen/go-fuse repo.
Briefly, on Linux, when the same process that's serving a fuse mountpoint is sending epoll requests to that mountpoint (as is common in tests), the go runtime can deadlock. This works around the issue with a nasty hack that forces the kernel to learn (and cache) the fact that polling is not implemented right after the mount happens, to avoid deadlocks when the test later makes the same request.
Issue: golang/go#21014
Issue: hanwen/go-fuse#165
Issue: bazil#183