Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be nice for KeyManager.generate to support multiple userids #45

Closed
gabriel opened this issue Oct 20, 2014 · 7 comments
Closed

Would be nice for KeyManager.generate to support multiple userids #45

gabriel opened this issue Oct 20, 2014 · 7 comments

Comments

@gabriel
Copy link

gabriel commented Oct 20, 2014

Would be good to specify multiple userids on key generation, so you can add a users real email and their keybase info:

userid: ["Test User <test@user.com>", "keybase.io/testuser <testuser@keybase.io>"]
@maxtaco
Copy link
Contributor

maxtaco commented Oct 20, 2014

This is an easy fix, I'll get right on it.

@maxtaco
Copy link
Contributor

maxtaco commented Oct 20, 2014

Live in 1.1.4, please report any bugs!

@gabriel
Copy link
Author

gabriel commented Oct 20, 2014

minor bug, you'll need to update generate_rsa and generate_ecc to pass
through userids too

On Mon, Oct 20, 2014 at 1:18 PM, Maxwell Krohn notifications@github.com
wrote:

Live in 1.1.4, please report any bugs!


Reply to this email directly or view it on GitHub
#45 (comment).

@gabriel
Copy link
Author

gabriel commented Oct 20, 2014

Also, when passing in multiple userids, there is no primary set.

The order of userids is also kind of random in the list because of hashing?

For example I generate a key with the userids (in this order):

Test User <test@example.com>
keybase.io/testuser <testuser@keybase.io>
Test User <test2@example.com>

And in gpgtools, there is no primary and order is random:
http://glui.me/?i=9vbst3n7w0jchoo/2014-10-20_at_2.57_PM.png/

On Mon, Oct 20, 2014 at 2:51 PM, Gabriel Handford gabrielh@gmail.com
wrote:

minor bug, you'll need to update generate_rsa and generate_ecc to pass
through userids too

On Mon, Oct 20, 2014 at 1:18 PM, Maxwell Krohn notifications@github.com
wrote:

Live in 1.1.4, please report any bugs!


Reply to this email directly or view it on GitHub
#45 (comment).

@maxtaco
Copy link
Contributor

maxtaco commented Oct 20, 2014

Noted, both issues. I'll take a look tomorrow. Thanks Gabriel

@maxtaco maxtaco reopened this Oct 20, 2014
maxtaco added a commit that referenced this issue Oct 21, 2014
@maxtaco
Copy link
Contributor

maxtaco commented Oct 21, 2014

Ok, fixed in 1.1.5, give it a whirl!

@maxtaco maxtaco closed this as completed Oct 21, 2014
@gabriel
Copy link
Author

gabriel commented Oct 21, 2014

yep works thanks!

On Mon, Oct 20, 2014 at 5:48 PM, Maxwell Krohn notifications@github.com
wrote:

Closed #45 #45.


Reply to this email directly or view it on GitHub
#45 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants