add length checks to Vouch #176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heronhaye
reviewed
Apr 8, 2020
| if err? | ||
| cb err | ||
|
|
||
| for text in obj.vouch_text |
There was a problem hiding this comment.
instead of this probably add to the string schema so you can do schema.string_with_max_length(700)) above and get it for free
that being said, this cb stuff is just continuation-passing so you have to return whenever you do a cb unless its at the end of the function, so you can fix this code with s/cb/return cb
|
closing this; superseded by #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.