add length check to vouch text #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heronhaye
approved these changes
Apr 8, 2020
src/schema3.iced
Outdated
| _check : ({path, obj}) -> | ||
| if typeof(obj) isnt 'string' or obj.length is 0 then return mkerr path, "value must be a string" | ||
| if @_args? and @_args.maxLength? |
There was a problem hiding this comment.
if you like, you can do if (max_length = @_args?.max_length)? as well, then use that value in the next block
test/files/wot.iced
Outdated
| verifier = alloc out.inner.obj.body.type, me | ||
| varg = { armored : out.armored, skip_ids : true, make_ids : true, inner : out.inner.str, expansions : out.expansions, require_packet_hash :true} | ||
| await verifier.verify_v2 varg, defer err | ||
| T.assert err?, "expecting error" |
There was a problem hiding this comment.
should check the specific type of error. seems to be a bit annoying in this case (thanks javascript), maybe you can just T.assert err?.message.includes("vouch.confidence.other")
(but @mlsteele may have a stronger opinion)
mlsteele
approved these changes
Apr 9, 2020
mmou
force-pushed
the
mmou/PICNIC-1059-len
branch
from
bac147b
to
af425fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is branched off of #177, so merge that first