hybrid boot keyboard #1361
Merged
hybrid boot keyboard #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlyu
force-pushed
the
hybrid-bootkb
branch
2 times, most recently
from
0685e00
to
58870d6
Compare
|
I would appreciate it of someone for whom the simulator tests work could try running them on this PR. (Workflows will fail because there's no way to pull in the matching KeyboardioHID commit.) I'm having trouble getting the simulator tests to work on macOS, possibly due to XCode linker bugs. I think I fixed the compilation bugs with the simulator, but due to linker failures, I can't run the tests locally. |
|
Fixed a few things I missed in the simulator tests. Dirty fixes added for macOS linker stuff. Will split and make separate PRs later. |
tlyu
force-pushed
the
hybrid-bootkb
branch
2 times, most recently
from
f1de869
to
5b9c05d
Compare
Make the Boot Keyboard the only keyboard, and make it have a hybrid report format in Report Protoocol, while still ending Boot Reports in Boot Protocol. The hybrid reports have the Boot Report as a prefix, which might help hosts that don't request Boot Protocol but still expect to see it. Adjust USBQuirks to switch between always Boot Protocol and the hybrid report. Add visual feedback about the target mode to USBQuirks. Signed-off-by: Taylor Yu <code@argon.blue>
monadplus
pushed a commit
to monadplus/Kaleidoscope
that referenced
this pull request
Dec 22, 2023
Switch to a hybrid keyboard report format, which @tlyu has built out and several end users have tested as performing better on a variety of temperamental operating systems that don't support NKRO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the Boot Keyboard the only keyboard, and make it have a hybrid
report format in Report Protoocol, while still ending Boot Reports in
Boot Protocol. The hybrid reports have the Boot Report as a prefix,
which might help hosts that don't request Boot Protocol but still
expect to see it.
Adjust USBQuirks to switch between always Boot Protocol and the
hybrid report.
Add visual feedback about the target mode to USBQuirks.
Requires keyboardio/KeyboardioHID#100, and is probably not safe to apply independently of it.edit: no longer requires it, because KeyboardioHID has been merged into Kaleidoscope, and I updated the patches accordingly.
Fixes #1305.