Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

[KEYCLOAK-11457] Backport of ubi8-minimal changes #219

Merged
merged 1 commit into from Oct 1, 2019
Merged

[KEYCLOAK-11457] Backport of ubi8-minimal changes #219

merged 1 commit into from Oct 1, 2019

Conversation

douglaspalmer
Copy link
Contributor

No description provided.

@stianst
Copy link
Contributor

stianst commented Sep 23, 2019

Shouldn't we wait for #217 to be resolved?

@abstractj
Copy link
Contributor

@douglaspalmer I'm very confused. I could not spot the difference between this PR and #217. If there's some, why not address in the same PR?

@abstractj abstractj self-assigned this Sep 25, 2019
@stianst
Copy link
Contributor

stianst commented Sep 26, 2019

@abstractj this PR is for REL branch which will be used for KC 7.0.1. Next release from master will be 8.

@abstractj
Copy link
Contributor

Damn, I missed the branch. Sorry about that.

@stianst
Copy link
Contributor

stianst commented Sep 26, 2019

Not the first time - the branch is not obvious at all. I've merged PRs to maintenance branches in the past by mistake.

@abstractj abstractj added the Hold label Sep 27, 2019
@abstractj
Copy link
Contributor

@stianst should we merge this one too?

@stianst stianst merged commit 79aa685 into keycloak:REL Oct 1, 2019
@@ -17,7 +17,7 @@ ARG KEYCLOAK_DIST=https://downloads.jboss.org/keycloak/$KEYCLOAK_VERSION/keycloa

USER root

RUN yum update -y && yum install -y epel-release git && yum install -y jq openssl which && yum clean all

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you removed jq, it was used for custom scripts parsing the external ip when binding public interfaces in aws.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmanolache please follow up on keycloak-user mailing list, we do not keep track of comments on closed pull requests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants