document compatibility mode for oidc logout endpoint suppression #1652
Conversation
bs-matil
force-pushed
the
13469-logout-endpoint-fully-compatible-to-previous-keycloak-versions
branch
2 times, most recently
from
ecb57f7
to
9b539d6
Compare
There was a problem hiding this comment.
@bs-matil Thanks for the documentation PR!
I have 2 suggestions:
-
Is it possible to include the same/similar warning like at the end of the section https://www.keycloak.org/docs/latest/upgrading/index.html#openid-connect-logout ? It is still subject to discuss if the switch is going to be removed in Keycloak 21 (I have the email discussion with @sschu regarding this), however it would be good to make it clear that switch exists just for the backwards compatibility
-
This will be added in Keycloak 19.0.2 and hence will be good to add to the file for 19.0.2 instead of the existing 19.0.0, which is already released. You can possibly create file changes-19_0_2.adoc and include it from this file https://github.com/keycloak/keycloak-documentation/blob/main/upgrading/topics/keycloak/changes.adoc .
Besides that, I am adding also @amunro as a reviewer to this PR
bs-matil
force-pushed
the
13469-logout-endpoint-fully-compatible-to-previous-keycloak-versions
branch
4 times, most recently
from
9242a26
to
5c3729a
Compare
|
@andymunro @mposolda I incorporated the changes. |
bs-matil
force-pushed
the
13469-logout-endpoint-fully-compatible-to-previous-keycloak-versions
branch
from
5c3729a
to
7ca7710
Compare
bs-matil
force-pushed
the
13469-logout-endpoint-fully-compatible-to-previous-keycloak-versions
branch
from
7ca7710
to
33b9855
Compare
|
Thank you @bs-matil for making these changes and keeping our documentation up to date. |
There was a problem hiding this comment.
@bs-matil @andymunro Thanks for the review and changes!
I am merging this. I will just update a version in the follow-up commit for removing this flag from Keycloak 21 to Keycloak 23 (discussed by email with @sschu)
fixes docs for keycloak/keycloak#13469