KEYCLOAK-2898 Fix GroupMappersTest on wildfly. Clearing AssertEvents …

…events queue before test instead of after
keycloak · Apr 26, 2016 · 225523f · 225523f
1 parent 4433a05
commit 225523f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/...tion-arquillian/tests/base/src/test/java/org/keycloak/testsuite/AbstractKeycloakTest.java b/...tion-arquillian/tests/base/src/test/java/org/keycloak/testsuite/AbstractKeycloakTest.java
@@ -133,7 +133,7 @@ public void beforeAbstractKeycloakTest() throws Exception {
                 MASTER, ADMIN, ADMIN, Constants.ADMIN_CLI_CLIENT_ID);
         deleteMeOAuthClient = new DeleteMeOAuthClient(AuthServerTestEnricher.getAuthServerContextRoot() + "/auth");
 
-        testingClient = KeycloakTestingClient.getInstance(AuthServerTestEnricher.getAuthServerContextRoot() + "/auth");
+        getTestingClient();
 
         adminUser = createAdminUserRepresentation();
 
@@ -188,6 +188,13 @@ public void setDefaultPageUriParameters() {
         loginPage.setAuthRealm(MASTER);
     }
 
+    protected KeycloakTestingClient getTestingClient() {
+        if (testingClient == null) {
+            testingClient = KeycloakTestingClient.getInstance(AuthServerTestEnricher.getAuthServerContextRoot() + "/auth");
+        }
+        return testingClient;
+    }
+
     public abstract void addTestRealms(List<RealmRepresentation> testRealms);
 
     private void addTestRealms() {

diff --git a/.../integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/AssertEvents.java b/.../integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/AssertEvents.java
@@ -63,12 +63,9 @@ public Statement apply(final Statement base, org.junit.runner.Description descri
         return new Statement() {
             @Override
             public void evaluate() throws Throwable {
-                try {
-                    base.evaluate();
-                } finally {
-                    // TODO Test should fail if there are leftover events
-                    context.testingClient.testing().clearQueue();
-                }
+                context.getTestingClient().testing().clearQueue();
+                base.evaluate();
+                // TODO Test should fail if there are leftover events
             }
         };
     }

diff --git a/...uillian/tests/base/src/test/java/org/keycloak/testsuite/admin/group/GroupMappersTest.java b/...uillian/tests/base/src/test/java/org/keycloak/testsuite/admin/group/GroupMappersTest.java
@@ -109,7 +109,6 @@ private ClientRepresentation getClientByAlias(RealmRepresentation testRealmRep,
     @Test
     @SuppressWarnings("unchecked")
     public void testGroupMappers() throws Exception {
-        events.clear();
         RealmResource realm = adminClient.realms().realm("test");
         {
             UserRepresentation user = realm.users().search("topGroupUser", -1, -1).get(0);