CreatedTimestamp on REST import not used

[heddn]

Description

The CreatedTimestamp (if set on the user rest creation call) is always discarded in favor of Time.currentTimeMillis(). This shouldn't be the case for scenarios when someone is REST importing from a legacy system.

Discussion

No response

Motivation

Handle graceful import of users from legacy systems.

Details

From MapUserProvider.

[efesler]

In LegacyExportImportManager.createUser, the createdTimeStamp is set to the timestamp coming from the legacy repository.

// Import users just to user storage. Don't federate
        UserModel user = UserStoragePrivateUtil.userLocalStorage(session).addUser(newRealm, userRep.getId(), userRep.getUsername(), false, false);
        user.setEnabled(userRep.isEnabled() != null && userRep.isEnabled());
        user.setCreatedTimestamp(userRep.getCreatedTimestamp());

Is the issue still relevant ?

[heddn]

I'm dusting off the user migration again and will confirm. But LegacyExportImportManager and MapUserProvider are different things. The REST import should pass through this code. And

keycloak/model/map/src/main/java/org/keycloak/models/map/user/MapUserProvider.java

Line 360 in 6830735

entity.setCreatedTimestamp(Time.currentTimeMillis());

still has the hard coded timestamp.

[heddn]

No, the provided value from the REST import is not used. It still uses the time of import instead of the value provided in the import.

[heddn]

I'm looking at org.keycloak.services.resources.admin.UsersResource::createUser, and there is nothing to set the create timestamp.

[heddn]

Just pushed up a PR that should at least start the conversation here.