Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate realms if configured to use RH-SSO themes #17484

Closed
mposolda opened this issue Mar 7, 2023 · 0 comments · Fixed by #19963
Closed

Migrate realms if configured to use RH-SSO themes #17484

mposolda opened this issue Mar 7, 2023 · 0 comments · Fixed by #19963
Assignees
@rmartinc
Labels
kind/enhancement Categorizes a PR related to an enhancement priority/important Must be worked on very soon
Milestone
22.0.0

Comments

@mposolda
Copy link
Contributor

mposolda commented Mar 7, 2023

Description

In Keycloak 22 there will no longer be RH-SSO themes. This may result in an issue when customers are upgrading to Keycloak 22 from RH-SSO if they have explicitly used the RH-SSO themes for realms or clients.

We should add a migration to replace RH-SSO themes with Keycloak themes.

Done for the new admin console already:
https://github.com/keycloak/keycloak/blob/main/model/legacy-private/src/main/java/org/keycloak/migration/migrators/MigrateTo21_0_0.java

We'll need to do the same for login and new account console.

For realms we can do it as above, but for clients that may be more complicated as we can't really iterate over all the clients in all realms.

This is only relevant for the old store, so we can consider doing an custom SQL migration in Liquibase that will be more efficient.

Discussion

No response

Motivation

No response

Details

No response
@mposolda mposolda added kind/enhancement Categorizes a PR related to an enhancement status/triage labels Mar 7, 2023
@mposolda mposolda added this to the 22.0.0 milestone Mar 7, 2023
@mposolda mposolda added priority/important Must be worked on very soon team/core and removed status/triage labels Mar 7, 2023
rmartinc added a commit to rmartinc/keycloak that referenced this issue Apr 25, 2023
@rmartinc
Migrate realms if configured to use RH-SSO themes keycloak#17484
ce1a44f 
Closes keycloak#17484
rmartinc added a commit to rmartinc/keycloak that referenced this issue Apr 25, 2023
@rmartinc
Migrate realms if configured to use RH-SSO themes keycloak#17484
a184c35 
Closes keycloak#17484
rmartinc added a commit to rmartinc/keycloak that referenced this issue Apr 26, 2023
@rmartinc
Migrate realms if configured to use RH-SSO themes
dfb1896 
Closes keycloak#17484
@rmartinc rmartinc mentioned this issue Apr 26, 2023
Merged
rmartinc added a commit to rmartinc/keycloak that referenced this issue Apr 27, 2023
@rmartinc
Migrate realms if configured to use RH-SSO themes
95e27a9 
Closes keycloak#17484
mposolda pushed a commit that referenced this issue May 2, 2023
@rmartinc @mposolda
Migrate realms if configured to use RH-SSO themes
d9025db 
Closes #17484
arthur25000 pushed a commit to arthur25000/keycloak that referenced this issue May 4, 2023
@rmartinc
Migrate realms if configured to use RH-SSO themes
6520102 
Closes keycloak#17484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmartinc rmartinc

Labels
kind/enhancement Categorizes a PR related to an enhancement priority/important Must be worked on very soon
Projects
None yet
Milestone
22.0.0
Development

Successfully merging a pull request may close this issue.

Migrate realms if configured to use RH-SSO themes rmartinc/keycloak
2 participants
@mposolda @rmartinc