Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML client import cert pem file for "Encryption keys config" broken #17876

Closed
2 tasks done
wilderk opened this issue Jan 5, 2023 · 6 comments
Closed
2 tasks done

SAML client import cert pem file for "Encryption keys config" broken #17876

wilderk opened this issue Jan 5, 2023 · 6 comments
Assignees
Labels
Milestone

Comments

@wilderk
Copy link

wilderk commented Jan 5, 2023

Before reporting an issue

  • I have searched existing issues
  • I have reproduced the issue with the latest release

Area

admin/ui

Describe the bug

Admin Console at /master/console/#/{realm}/clients/{id}/keys. Tried to import client certificate pem file for the "Signing keys config". Instead of updating "Signing keys config" certificate the "Encryption keys config" certificate was updated. No way to update the certificate for "Signing keys config" from the Admin Console.

Version

Keycloak Quarkus 20.0.2

Expected behavior

The client app certificate pem file is imported to the "Signing keys config"

Actual behavior

The "Signing keys config" certificate is not updated and remains as the default generated certificate.

How to Reproduce?

  1. Log in to master realm
  2. Navigate to application realm
  3. Navigate to a SAML client on the keys tab at /master/console/#/{realm}/clients/{id}/keys
  4. Attempt to import certificate for "Signing keys config"

Anything else?

Currently the workaround is to disable the "Signing keys config" client signature.
Can anyone provide the commands to update the "Signing keys config" certificate using api?

@wilderk wilderk added kind/bug Categorizes a PR related to a bug status/triage labels Jan 5, 2023
@ghost ghost added the area/admin/ui label Jan 5, 2023
@ssilvert
Copy link
Contributor

ssilvert commented Jan 6, 2023

I have verified that the new console is calling the wrong API. It is calling /certificates/saml.encryption/upload instead of /certificates/saml.signing/upload.

Moving issue to keycloak-ui repo.

@ssilvert
Copy link
Contributor

ssilvert commented Jan 6, 2023

@wilderk As a workaround until this is fixed, you can use the old admin console. Just go to Ream settings -> Themes and change the admin theme to keycloak. The refresh your browser.

@ssilvert ssilvert transferred this issue from keycloak/keycloak Jan 6, 2023
@wilderk
Copy link
Author

wilderk commented Jan 9, 2023

Thanks @ssilvert. I confirmed the workaround by changing the "Admin Console Theme" in the "master" realm to the old "keycloak" theme.

@edewit
Copy link
Contributor

edewit commented Jan 10, 2023

okay this UI might be a bit strange, but in order to upload the signing keys you should first disable Client signature required and then turn it on again. Only the a dialog will appear to import the signing keys:
image

@wilderk
Copy link
Author

wilderk commented Jan 13, 2023

@edewit - This issue is not about whether or not the import dialog is visible. There is a confirmed problem in the code. The wrong API is being called.

@edewit
Copy link
Contributor

edewit commented Jan 16, 2023

@wilderk yes you are right, I was confused, let me fix that right now

edewit referenced this issue in edewit/keycloak-admin-ui Jan 16, 2023
jonkoops referenced this issue in edewit/keycloak-admin-ui Jan 16, 2023
@ssilvert ssilvert transferred this issue from another repository Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants