Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX Review] Fine-tuning of the multiple values field #18175

Closed
xianli123 opened this issue Jul 26, 2022 · 8 comments
Closed

[UX Review] Fine-tuning of the multiple values field #18175

xianli123 opened this issue Jul 26, 2022 · 8 comments
Labels
impact/low kind/bug Categorizes a PR related to a bug team/ui
Milestone

Comments

@xianli123
Copy link
Contributor

Describe the bug

In the new UI, there are some fields that can be filled by multiple values as shown below. Taking the Valid redirect URIs as an example, when there are multiple values, each value should be able to delete, so the remove icon should be clickable for all fields.

Screen Shot 2022-07-26 at 11 04 55

Version

Admin new UI

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Anything else?

No response

@xianli123 xianli123 added kind/bug Categorizes a PR related to a bug impact/low labels Jul 26, 2022
@xianli123 xianli123 added this to the 20.0.0 milestone Jul 26, 2022
@edewit
Copy link
Contributor

edewit commented Aug 4, 2022

Right I guess it should be the other way around only the first field can't be deleted

@edewit
Copy link
Contributor

edewit commented Aug 4, 2022

That way you can always return to the initial state:
image

edewit referenced this issue in edewit/keycloak-admin-ui Aug 4, 2022
@jonkoops jonkoops closed this as completed Aug 5, 2022
@xianli123
Copy link
Contributor Author

Hi @edewit @jonkoops I think it will be better if each value can be removed. What do you think?

@jonkoops
Copy link
Contributor

jonkoops commented Aug 9, 2022

Can you log a new issue for it Kun?

@edewit
Copy link
Contributor

edewit commented Aug 9, 2022

but @xianli123 when I remove the last field there will be nothing left? Is that what you want like this:
image

@xianli123
Copy link
Contributor Author

Hi @edewit No. We should allow users to delete one specific field(including the last one), not all fields.

@edewit
Copy link
Contributor

edewit commented Aug 15, 2022

ahh okay so you mean only disable the first field if the first field is the only field

@xianli123
Copy link
Contributor Author

xianli123 commented Aug 16, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/low kind/bug Categorizes a PR related to a bug team/ui
Projects
None yet
Development

No branches or pull requests

4 participants