Sort subgroups

[npriebe]

Before reporting an issue

• I have searched existing issues
• I have reproduced the issue with the latest release

Area

account/api

Describe the bug

Hi,

I have updated my Keycloak from 19.0.2 to 21.0.1.
Now I have the problem that the groups are not sorted. It doesn't matter whether I create new groups or move existing ones.

However, if I now set up a new Keycloak instance, the sorting works properly when creating and moving groups.

Here an example of my groups:

Version

21.0.1

Expected behavior

Actual behavior

How to Reproduce?

Anything else?

No response

[vramik]

Hello @npriebe, thanks for the report. Could you please share more information regarding database you're using?

[npriebe]

Hi @vramik , my Keycloak is running under Docker for now the database is running under a MySQL server.
The server data are:

Server type: MySQL
Server version: 5.7.12 - MySQL Community Server (GPL)
Protocol version: 10
Server charset: cp1252 West European (latin1)

[vramik]

Thanks @npriebe, could you please elaborate a bit more on the sorting itself? I was digging in a code and found out that top level groups should be sorted by its name:

keycloak/model/jpa/src/main/java/org/keycloak/models/jpa/entities/GroupEntity.java

Line 38 in e9accaf

@NamedQuery(name="getTopLevelGroupIds", query="select u.id from GroupEntity u where u.parentId = :parent and u.realm = :realm order by u.name ASC"),

while subgroups have no ordering what so ever (unless sorted by ui):

keycloak/model/jpa/src/main/java/org/keycloak/models/jpa/entities/GroupEntity.java

Line 31 in e9accaf

@NamedQuery(name="getGroupIdsByParent", query="select u.id from GroupEntity u where u.parentId = :parent"),

I got consistent finding with both migrating from 19.0.2 to 21.0.1 and 21.0.1 started from scratch.

If the issue is about sorting subgroups, I'll change it to enhancement.

[npriebe]

Thank you for your efforts @vramik

I had tested this again and as it is described in the code, the top groups are sorted cleanly.
Furthermore, I had also looked again since which version the groups already exist in my keycloak. I have been using Keycloak since version 4.8.2 and in this version the groups already existed. Maybe they were already in the wrong order at that time.

I had also set up a completely new keycloak from scratch, where these problems did not occur afterwards. So it could really have been a problem with the group UI at the time.

It would therefore make sense if the sub-groups were also sorted by name as standard, so that this is consistent with the top groups.

[vramik]

Thanks @npriebe, I agree it makes sense to sub-groups to be sorted as well. As it's not a regression I'll switch the issue to enhancement.

[transducer]

We would also like to see sorted subgroups.

[npriebe]

@vramik In which version will the improvement be available? Could you possibly add a milestone to the issue?

[vramik]

@npriebe it should be available in 23.0.0.