Incorrect function is used in 'keycloak-admin-client' library in getToken function

[lexakozakov]

Before reporting an issue

• I have searched existing issues
• I have reproduced the issue with the latest release

Area

adapter/javascript

Describe the bug

It looks like it's just a simple mistake - 'atob' function is used instead of 'btoa'

Version

2022.9

Expected behavior

'btoa' function should be used

Actual behavior

'atob' function is used

How to Reproduce?

just run getToken function

Anything else?

No response

[hmica]

Hi, I got the same issue while upgrading to admin@21.1.1

it's seems there is an error in auth.ts

keycloak/js/libs/keycloak-admin-client/src/utils/auth.ts

Lines 80 to 83 in f7988a6

	headers.set(
	"Authorization",
	atob(credentials.clientId + ":" + credentials.clientSecret)
	);

The correct header should be something like this :

 headers.set("Authorization","Basic "+btoa(credentials.clientId + ":" + credentials.clientSecret));

Thank you

[lexakozakov]

BTW, authorization does not work properly even the function is changed to btoa.

clientId and clientSecret should be sent in request body.

https://github.com/lexakozakov/keycloak/blob/main/js/libs/keycloak-admin-client/src/utils/auth.ts#L66

[jonkoops]

Hi @hmica, would you be willing to submit a pull request to fix this? We'll try to backport it to a patch release.

[jonkoops]

I see you already did, will take a look at it 👍

[guesant]

Same issue here.

DOMException [InvalidCharacterError]: Invalid character