New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown options on Documentation pointing to 21.1 endpoint instead of latest and throwing 404 when clicking on it. #19974
Comments
I'm happy to submit a PR for this one, Any guidance for solving this would be appreciated, thanks! |
Apparently no code changes are needed here, keycloak/docs/documentation/pom.xml Line 65 in 8367f8f
|
This was a regression due to migrating the documentation repository to the main repository that changed the way we build the docs. If I remember correctly we used to build both a |
@ahus1 FIY |
@stianst - sorry that I've missed that. I see you assigned it to you ... feel free to assign it to me and I'll work on this from tomorrow? |
@ahus1 if you could handle it that'd be great. Was probably me that missed this not you 😉 |
@BrayanMnz - If you want to create a pull request with the necessary changes, go ahead. I still need to figure out what needs to change here. As an alternative I'd be happy for a reviewer once I have created one. If I don't hear from you I will start having a look on Monday the latest. |
@stianst - I analyzed the current behavior, and this is what I found:
Do we want to keep the functionality for "latest" vs. "archive", or would we rather drop it? It seems to be broken from KC 20.0.0 onward once the symlink was used. From then on, even the old version shows latest, see for example https://www.keycloak.org/docs/20.0.5/securing_apps/index.html If we drop it, we could have it again once we migrate to a tool like Antora. Antora will re-render all the old docs with their AsciiDoc content when publishing. If we want to keep it, it could be solved by adding some JavaScript, which I'd rather not. So I'd like to go ahead and remove the "latest" vs. "archive" feature. In this case it would behave like in the KC20 releases where when switching the guides, it would always jump to the latest version. And the yellow vs green text will be removed. Please confirm. |
There are now two PR which will fix part of the problems: |
…eycloak#20035) Relates to keycloak#19974 (cherry picked from commit ff28418)
Relates to keycloak#19974 (cherry picked from commit ff28418)
This is done as the docs are no longer built twice. Closes keycloak#19974
This is done as the docs are no longer built twice. Closes keycloak#19974
PR to remove latest vs. archive from the document header: #20103 |
This is done as the docs are no longer built twice. Closes #19974
This is done as the docs are no longer built twice. Closes keycloak#19974 (cherry picked from commit 75ea22b)
Backport created: #20110 |
PR to fix the old docs created: keycloak/keycloak.github.io#21 |
This is done as the docs are no longer built twice. Closes keycloak#19974
Before reporting an issue
Area
docs
Describe the bug
When on the documentation page, for example: https://www.keycloak.org/docs/latest/server_development/
and hovering the mouse over the top left Server Developer dropdown, the options on the dropdown are redirecting to a path like this one https://www.keycloak.org/docs/21.1/securing_apps/
See the 21.1 on the version fragment of the uri, this should be latest I think.
if you click on it you'll see that it throws a 404
Version
latest
Expected behavior
It should redirect to the correct page instead of throwing a 404
Actual behavior
404
How to Reproduce?
When on the documentation page, for example: https://www.keycloak.org/docs/latest/server_development/
and hovering the mouse over the top left Server Developer dropdown, the options on the dropdown are redirecting to a path like this one https://www.keycloak.org/docs/21.1/securing_apps/
Anything else?
No response
The text was updated successfully, but these errors were encountered: