Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak 21.1.1: Paging and filtering not working in "Assign roles" popup for Groups #19981

Closed
2 tasks done
lrozenblyum opened this issue Apr 27, 2023 · 6 comments · Fixed by #20102
Closed
2 tasks done
Assignees
Labels
Milestone

Comments

@lrozenblyum
Copy link
Contributor

lrozenblyum commented Apr 27, 2023

Before reporting an issue

  • I have searched existing issues
  • I have reproduced the issue with the latest release

Area

admin/ui

Describe the bug

In the new Admin UI, in "Role Mapping" tab for a group, when clicking on "Assign roles" button, the popup will display only the first page of role results. Clicking on next, will display the same first page of results, so its not possible to display subsequent pages.

When entering search term in "Search by role name" field, the search term doesn't affect the result, but the same unfiltered first page of results is displayed.

The requests sent to keycloak server:

/groups/b06c2caa-7742-4747-9f96-8fcd78c43cc8/role-mappings/realm/available?first=0&max=11 - result contains all 21 roles (I have 21 in the realm), but the UI displays only first 10
/groups/b06c2caa-7742-4747-9f96-8fcd78c43cc8/role-mappings/realm/available?first=10&max=11 - result contains all 21 roles (I have 21 in the realm), but the UI displays only first 10
/groups/b06c2caa-7742-4747-9f96-8fcd78c43cc8/role-mappings/realm/available?first=0&max=11&search=test - result contains all 21 roles (I have 21 in the realm), but the UI displays only first 10

Theories: it's either a backend issue, or the parameter names sent from the frontend are incorrect.

Version

21.1.1

Expected behavior

  • Clicking on next should display next page instead of first page only
  • Entering search term should display only matching roles

Actual behavior

  • Clicking on next shows first page only
  • Entering search term has no effect on search results (non-matching roles are retrieved)

How to Reproduce?

  • Add more then 10 roles to the realm
  • See that paging and filtering on "Assign roles" popup don't work

Anything else?

No response

@lrozenblyum lrozenblyum added kind/bug Categorizes a PR related to a bug status/triage labels Apr 27, 2023
@lrozenblyum lrozenblyum changed the title Keycloak 21.1.1: Paging and filtering not working in "Assign roles" popup" Keycloak 21.1.1: Paging and filtering not working in "Assign roles" popup for Groups Apr 27, 2023
@ssilvert
Copy link
Contributor

I have reproduced this bug. Attaching a partial import file to create 150 roles.

realm-role-many.zip

edewit added a commit to edewit/keycloak that referenced this issue May 3, 2023
@edewit edewit mentioned this issue May 3, 2023
@jonkoops jonkoops added this to the 21.1.2 milestone May 3, 2023
@lrozenblyum
Copy link
Contributor Author

lrozenblyum commented May 3, 2023 via email

edewit added a commit to edewit/keycloak that referenced this issue May 4, 2023
arthur25000 pushed a commit to arthur25000/keycloak that referenced this issue May 4, 2023
@edewit
Copy link
Contributor

edewit commented May 9, 2023

@lrozenblyum yes that has been done in #20142

@frankXorFox
Copy link

Hi guys - thanks for working on this. In a bit of a panic this weekend because we just went over 100+ roles in a major installation and can't assign roles via the admin ui due to this issue. I just wanted to comment that the description mentions 'groups', but it happens on 'user' role assignments as well. I understand that this may use the same dialog/popup as groups. But I just thought I'd mention it. Thanks again for working on it.

@edewit
Copy link
Contributor

edewit commented Jun 13, 2023

@frankXorFox you can try it out with the nightly release

@lrozenblyum
Copy link
Contributor Author

@frankXorFox 21.1.2 is released and includes the fix for this issue, you may give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants