Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keycloakCRName and realm are no longer marked as required in KeycloakRealmImport CRD #21607

Closed
2 tasks done
vmuzikar opened this issue Jul 11, 2023 · 4 comments · Fixed by #21608 or #21634
Closed
2 tasks done

keycloakCRName and realm are no longer marked as required in KeycloakRealmImport CRD #21607

vmuzikar opened this issue Jul 11, 2023 · 4 comments · Fixed by #21608 or #21634
Assignees
@vmuzikar
Labels
area/operator Keycloak.X Operator kind/bug Categorizes a PR related to a bug team/cloud-native
Milestone
22.0.1

Comments

@vmuzikar
Copy link
Contributor

Before reporting an issue

Area

operator

Describe the bug

keycloakCRName and realm fields are no longer marked as required.

Version

22.0.0

Expected behavior

Marked as required

Actual behavior

Not marked as required

How to Reproduce?

Diff the CRD for 21.1.2 and 22.0.0.

Anything else?

No response
@vmuzikar vmuzikar added kind/bug Categorizes a PR related to a bug status/triage labels Jul 11, 2023
@ghost ghost added area/operator Keycloak.X Operator team/cloud-native labels Jul 11, 2023
@vmuzikar vmuzikar added this to the 22.0.1 milestone Jul 11, 2023
@vmuzikar
Copy link
Contributor Author

CC @shawkins

@vmuzikar
Copy link
Contributor Author

Mitigated this at least for OLM by manually fixing the CRD:
k8s-operatorhub/community-operators#2978
redhat-openshift-ecosystem/community-operators-prod#2933

vmuzikar added a commit to vmuzikar/keycloak that referenced this issue Jul 11, 2023
@vmuzikar
keycloakCRName and realm are now longer marked as required in Key…
c0102f3 
…cloakRealmImport CRD

Closes keycloak#21607
@vmuzikar vmuzikar mentioned this issue Jul 11, 2023
Merged
@vmuzikar vmuzikar self-assigned this Jul 11, 2023
@shawkins
Copy link
Contributor

shawkins commented Jul 11, 2023 •
edited

@vmuzikar this is coming from fabric8io/kubernetes-client#4597 via fabric8io/kubernetes-client#4348

Checking for validations unfortunately wasn't in scope for the simple round-trip tests to verify that noting is dropped with crd generation.

vmuzikar added a commit to vmuzikar/keycloak that referenced this issue Jul 11, 2023
@vmuzikar
keycloakCRName and realm are no longer marked as required in Keyc…
2fb19be 
…loakRealmImport CRD

Closes keycloak#21607
@vmuzikar vmuzikar changed the title keycloakCRName and realm are now longer marked as required in KeycloakRealmImport CRD keycloakCRName and realm are no longer marked as required in KeycloakRealmImport CRD Jul 11, 2023
vmuzikar added a commit to vmuzikar/keycloak that referenced this issue Jul 11, 2023
@vmuzikar
keycloakCRName and realm are no longer marked as required in Keyc…
baa3ab3 
…loakRealmImport CRD

Closes keycloak#21607
vmuzikar added a commit to vmuzikar/keycloak that referenced this issue Jul 11, 2023
@vmuzikar
keycloakCRName and realm are no longer marked as required in Keyc…
554b0b5 
…loakRealmImport CRD

Closes keycloak#21607
pedroigor pushed a commit that referenced this issue Jul 12, 2023
@vmuzikar @pedroigor
keycloakCRName and realm are no longer marked as required in Keyc…
6a3ea1a 
…loakRealmImport CRD

Closes #21607
@vmuzikar
Copy link
Contributor Author

Reopening for backport

@vmuzikar vmuzikar reopened this Jul 12, 2023
vmuzikar added a commit to vmuzikar/keycloak that referenced this issue Jul 12, 2023
@vmuzikar
keycloakCRName and realm are no longer marked as required in Keyc…
9720b11 
…loakRealmImport CRD

Closes keycloak#21607

(cherry picked from commit 6a3ea1a)
@vmuzikar vmuzikar mentioned this issue Jul 12, 2023
Merged
@vmuzikar vmuzikar linked a pull request Jul 14, 2023 that will close this issue
keycloakCRName and realm are no longer marked as required in KeycloakRealmImport CRD #21634
Merged
@vmuzikar vmuzikar mentioned this issue Jul 14, 2023
Merged
vmuzikar added a commit that referenced this issue Jul 17, 2023
@vmuzikar
keycloakCRName and realm are no longer marked as required in Keyc…
1c56f9e 
…loakRealmImport CRD (#21634)

Closes #21607

(cherry picked from commit 6a3ea1a)
@stianst stianst closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmuzikar vmuzikar

Labels
area/operator Keycloak.X Operator kind/bug Categorizes a PR related to a bug team/cloud-native
Projects
None yet
Milestone
22.0.1
3 participants
@stianst @shawkins @vmuzikar